[14/36] Add OC-100 request type UX - #48
Conversation
2554e5d to
8bac182
Compare
b7c26bd to
485d897
Compare
8bac182 to
def6356
Compare
def6356 to
9246f62
Compare
485d897 to
2a70d05
Compare
|
Verdict: approve with nits, but the first item is borderline request-changes and I'd fix it before merge.
Tests: good on the creation path (all four starters subschema-validated, real command flow, slug edges, identity guard). The gap is exactly where the bug is: nothing drives edit-then-save for gRPC through the webview build path, and the round-trip test asserts the no-op as if it were desired. Deps: none added, package.json changes are the color contributions only. |
|
Already addressed for the major finding. The false-success save path is real on this PR snapshot, but gRPC visual editing is implemented downstream in PR #52 ( Fixed for streaming sequences. On the topmost review-rework branch Not changing the protocol color contributions. Validation after the rework: 494 tests pass, TypeScript compilation passes, and the production build passes. PR #48 and its immediate child PR #49 both remain |
This is part 8 of 21 in a stack made with GitButler: