Skip to content

[11/36] Record OC-010 through OC-040 supervisor audit - #45

Open
cjohnsto-nz wants to merge 2 commits into
feature/oc-020-websocket-supportfrom
supervisor/oc-010-040-audit
Open

[11/36] Record OC-010 through OC-040 supervisor audit#45
cjohnsto-nz wants to merge 2 commits into
feature/oc-020-websocket-supportfrom
supervisor/oc-010-040-audit

Conversation

@cjohnsto-nz

@cjohnsto-nz cjohnsto-nz commented Jun 14, 2026

Copy link
Copy Markdown
Owner

@cjohnsto-nz
cjohnsto-nz force-pushed the feature/oc-020-websocket-support branch from a82f7dd to c72c827 Compare June 14, 2026 22:46
@cjohnsto-nz
cjohnsto-nz force-pushed the supervisor/oc-010-040-audit branch 2 times, most recently from 25cd41e to 4f97e4b Compare June 14, 2026 22:49
@cjohnsto-nz
cjohnsto-nz force-pushed the feature/oc-020-websocket-support branch from c72c827 to 94f34d6 Compare June 14, 2026 22:49
@cjohnsto-nz
cjohnsto-nz force-pushed the supervisor/oc-010-040-audit branch from 4f97e4b to d32476f Compare June 14, 2026 22:49
@cjohnsto-nz
cjohnsto-nz force-pushed the feature/oc-020-websocket-support branch from 94f34d6 to 87caf31 Compare June 14, 2026 22:50
@cjohnsto-nz
cjohnsto-nz force-pushed the supervisor/oc-010-040-audit branch from d32476f to 8e2092e Compare June 14, 2026 22:50
@cjohnsto-nz cjohnsto-nz changed the title supervisor/oc-010-040-audit [11/21] Record OC-010 through OC-040 supervisor audit Jun 14, 2026
@cjohnsto-nz cjohnsto-nz changed the title [11/21] Record OC-010 through OC-040 supervisor audit [11/27] Record OC-010 through OC-040 supervisor audit Jun 15, 2026
@cjohnsto-nz cjohnsto-nz changed the title [11/27] Record OC-010 through OC-040 supervisor audit [11/36] Record OC-010 through OC-040 supervisor audit Jun 15, 2026
@APKiwi

APKiwi commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Verdict: approve with nits. Internal consistency checks out: the 13-test claim matches the actual test file, and the audit honestly records the two real limitations (WS wiring not atomic to the OC-020 branch, WS/gRPC not running the runtime lifecycle), both accurate against the code.

  • Minor: every cited commit hash (d599906, a67a3ad, 7a9dea5, 872660b, 0daa7be, 02155e6, 166c297) is unresolvable, GitButler restacks rewrote them. The doc even warns about this. Evidence pointers that can't be followed aren't evidence, cite branches + paths instead.
  • Nit: an audit PR shipping functional package.json changes (the two Copilot tool modelDescription strings) is off-label. The strings themselves are accurate.

@cjohnsto-nz

Copy link
Copy Markdown
Owner Author

Fixed on the stack-tip rework branch fix/open-collection-pr-rework in a2f2b2e, in docs/open-collection-gap-analysis/AGENT_PROGRESS.md.

The rewritten OC-000 through OC-060 evidence pointers now name stable PR numbers, full branch names, and concrete implementation/test paths. This covers the seven stale hashes identified here and the stale OC-000 pointer found in the same audit table.

I did not put that documentation edit on PR #45. A pre-push three-way check against immediate child PR #46 produced a conflict in AGENT_PROGRESS.md, because later branches continue editing that ledger. The correction was therefore placed on the existing rework branch based on current stack-tip PR #71 (feature/oc-170-request-action-first-click) instead of forcing a restack through every descendant. PR #45 and PR #46 remain MERGEABLE/CLEAN at their unchanged heads.

Not changing the package.json model descriptions. The supervisor audit explicitly covered package/build/install verification and found that the Copilot-facing manifest metadata still described only the older HTTP/GraphQL surface. Correcting metadata to match the WebSocket and unary gRPC capabilities delivered across PRs #37, #39, #43, and #44 is an audit remediation, not unrelated runtime scope. Moving those two strings into an already-reviewed feature branch would rewrite lower stack history without improving behavior or ownership.

Validation on the rework branch: 491/491 tests passed, TypeScript compilation passed, and the production build passed after installing the committed lockfile dependencies. The rework branch is verified as a descendant of the current PR #71 stack tip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants