Skip to content

[12/36] Add OC-080 and OC-090 task tracks - #46

Open
cjohnsto-nz wants to merge 1 commit into
supervisor/oc-010-040-auditfrom
supervisor/add-oc080-oc090-tasks
Open

[12/36] Add OC-080 and OC-090 task tracks#46
cjohnsto-nz wants to merge 1 commit into
supervisor/oc-010-040-auditfrom
supervisor/add-oc080-oc090-tasks

Conversation

@cjohnsto-nz

@cjohnsto-nz cjohnsto-nz commented Jun 14, 2026

Copy link
Copy Markdown
Owner

@cjohnsto-nz
cjohnsto-nz force-pushed the supervisor/oc-010-040-audit branch from ae88021 to 25cd41e Compare June 14, 2026 22:46
@cjohnsto-nz
cjohnsto-nz force-pushed the supervisor/add-oc080-oc090-tasks branch from 7c7d3ba to 0038c19 Compare June 14, 2026 22:46
@cjohnsto-nz
cjohnsto-nz force-pushed the supervisor/oc-010-040-audit branch from 25cd41e to 4f97e4b Compare June 14, 2026 22:49
@cjohnsto-nz
cjohnsto-nz force-pushed the supervisor/add-oc080-oc090-tasks branch from 0038c19 to a4f17ca Compare June 14, 2026 22:49
@cjohnsto-nz
cjohnsto-nz force-pushed the supervisor/oc-010-040-audit branch from 4f97e4b to d32476f Compare June 14, 2026 22:49
@cjohnsto-nz
cjohnsto-nz force-pushed the supervisor/add-oc080-oc090-tasks branch from a4f17ca to ba2aa43 Compare June 14, 2026 22:49
@cjohnsto-nz
cjohnsto-nz force-pushed the supervisor/oc-010-040-audit branch from d32476f to 8e2092e Compare June 14, 2026 22:50
@cjohnsto-nz
cjohnsto-nz force-pushed the supervisor/add-oc080-oc090-tasks branch from ba2aa43 to 7b8fa8a Compare June 14, 2026 22:50
@cjohnsto-nz cjohnsto-nz changed the title Add residual OpenCollection task tracks [12/21] Add OC-080 and OC-090 task tracks Jun 14, 2026
@cjohnsto-nz cjohnsto-nz changed the title [12/21] Add OC-080 and OC-090 task tracks [12/27] Add OC-080 and OC-090 task tracks Jun 15, 2026
@cjohnsto-nz cjohnsto-nz changed the title [12/27] Add OC-080 and OC-090 task tracks [12/36] Add OC-080 and OC-090 task tracks Jun 15, 2026
@APKiwi

APKiwi commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Verdict: approve. Docs only, internally consistent with the audit PR before it: OC-080's stated gap correctly restates the runtime-lifecycle limitation the code actually has, the OC-070 rewrite is coherent with its new dependencies, and numbering lines up across board, dependency map, prompts and README. The renamed "Remaining Gap Evidence" file-path pointers are asserted rather than verified in-diff but nothing contradicts them.

@cjohnsto-nz

Copy link
Copy Markdown
Owner Author

Already addressed; no change is required on this planning branch.

I verified the evidence paths rather than treating them as assertions:

  • At the OC-070 planning point, src/commands/requestCommands.ts still creates only an HttpRequest starter.
  • src/services/requestExecutionService.ts applies the runtime lifecycle to HTTP and GraphQL, while WebSocket and gRPC dispatch directly to their clients; that is the OC-080 gap this task records.
  • The README's snippet path is stale on this historical branch: the implementation file is src/services/snippetExporter.ts, not src/services/snippetService.ts.
  • The gRPC streaming statement is a planning snapshot that was superseded by PR [04/36] Add OC-090 gRPC streaming support #38, branch feature/oc-090-grpc-streaming, which owns the streaming implementation and coverage in src/services/grpcClient.ts and test/grpcSupport.test.ts at the currently verified head 5b5164f.

The stale snippet link and open-gap wording are already corrected by PR #53, branch supervisor/final-opencollection-review, in docs/open-collection-gap-analysis/README.md at the currently verified head 72ae2dd. That final-state document links src/services/snippetExporter.ts and records unary/streaming gRPC as implemented. I am not duplicating that descendant-owned final-state rewrite on PR #46.

PR #46 and immediate child PR #47 remain MERGEABLE/CLEAN.

@APKiwi

APKiwi commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Re-review (whole-stack pass, per REVIEW_GUIDE.md)

This is a docs-only task-track PR, so the ledger is the deliverable. Its central claim about OC-090 is wrong against the code already in its own ancestry.

  • (high) AGENT_PROGRESS.md:69 logs OC-090 as Unclaimed ("Start after OC-030..."), and tasks/09-grpc-streaming.md:13-18 says streaming calls "are not executed" and the demo "proves unary and unsupported-streaming, not real streaming." Both are false here. feature/oc-090-grpc-streaming ([04/36] Add OC-090 gRPC streaming support #38) is a verified ancestor of this base. At this PR's head, src/services/grpcClient.ts already executes server/client/bidi streaming, test/grpcSupport.test.ts already passes every item in task 09's own suggested-tests table, and examples/demo-api/gRPC/ already has all the streaming fixtures. The dead GrpcStreamingUnsupportedError class is the only trace of the "unsupported" state the doc describes as current. Anyone using this ledger to find open work would spin up a redundant OC-090 implementation agent.
  • (medium) Same stale premise repeats in tasks/07-import-export-copilot.md ("If OC-090 lands first...") and tasks/08-runtime-non-http-protocols.md ("Covered by OC-090 after streaming execution exists"). OC-090 is order 04, both of those land later, and per the git evidence it already exists.
  • (low) README.md "Remaining Gap Evidence" cites src/services/snippetService.ts, which does not exist. The real file is src/services/snippetExporter.ts.

Verdict: changes-needed. Correct the OC-090 row to done with a pointer to #38 (2ac3bc4/06b8d83), reword task 09 to verification/hardening rather than net-new implementation, and fix the snippet path.

@cjohnsto-nz

Copy link
Copy Markdown
Owner Author

Response to the second review: the stale OC-090 documentation was a valid finding.

I corrected it on stack-tip rework PR #72 in b220ecb, rather than rewriting this historical planning branch. The OC-090 task now records PR #38 and commits 2ac3bc4/06b8d83 as complete, its former "Current Gap" is explicitly historical/closed, OC-070 states that streaming landed first, and OC-080 no longer describes streaming execution as future or unsupported. The nonexistent snippetService.ts pointer was already corrected to src/services/snippetExporter.ts.

The task board's OC-090 row is Done, and the exact full-stack verification passes build, TypeScript compile, 31 files / 539 tests, and 47/47 demo files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants