[03/36] Add OC-030 gRPC unary protobuf support - #37
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
fdeadfe to
6cb577c
Compare
2c3d58a to
c5dbae7
Compare
|
Verdict: request changes. The headline feature is dead code and an unrelated dep rides along.
Tests: good in isolation (real in-process server, metadata merge, auth, error paths) but nothing exercises real extension wiring, which is exactly how the missing registration slipped through. Deps: @grpc/grpc-js + @grpc/proto-loader are the right buy, canonical maintained packages, and hand-rolling protobuf/HTTP2 is not a realistic alternative. Transitive tree is the standard protobufjs stack, acceptable. Checked for vendored/minified/obfuscated blobs: none in this PR, all additions are declared npm packages with standard integrity hashes. The two real dep issues are the unused |
|
Already addressed in the complete stack where appropriate; the remaining items are intentional OC-030 boundaries.
The unary path is exercised against an in-process gRPC server, including proto imports, metadata precedence, interpolation, authentication, errors, and dispatch through an injected executor. No additional source changes are required on PR #37. The PR and its child edge are currently |
This is part 19 of 21 in a stack made with GitButler: