Skip to content

[07/36] Record OC-000 and OC-060 supervisor audit - #41

Open
cjohnsto-nz wants to merge 2 commits into
feature/oc-060-schema-roundtrip-validationfrom
supervisor/oc-000-oc-060-audit
Open

[07/36] Record OC-000 and OC-060 supervisor audit#41
cjohnsto-nz wants to merge 2 commits into
feature/oc-060-schema-roundtrip-validationfrom
supervisor/oc-000-oc-060-audit

Conversation

@cjohnsto-nz

@cjohnsto-nz cjohnsto-nz commented Jun 14, 2026

Copy link
Copy Markdown
Owner

@cjohnsto-nz
cjohnsto-nz force-pushed the feature/oc-060-schema-roundtrip-validation branch from e631d8a to e5c3f49 Compare June 14, 2026 22:45
@cjohnsto-nz
cjohnsto-nz force-pushed the supervisor/oc-000-oc-060-audit branch from c4c463b to 403e8cc Compare June 14, 2026 22:46
@cjohnsto-nz
cjohnsto-nz force-pushed the feature/oc-060-schema-roundtrip-validation branch from e5c3f49 to d67e365 Compare June 14, 2026 22:49
@cjohnsto-nz
cjohnsto-nz force-pushed the supervisor/oc-000-oc-060-audit branch from 403e8cc to ebff346 Compare June 14, 2026 22:49
@cjohnsto-nz
cjohnsto-nz force-pushed the feature/oc-060-schema-roundtrip-validation branch from d67e365 to da92a88 Compare June 14, 2026 22:50
@cjohnsto-nz
cjohnsto-nz force-pushed the supervisor/oc-000-oc-060-audit branch from ebff346 to 25b9a47 Compare June 14, 2026 22:50
@cjohnsto-nz cjohnsto-nz changed the title supervisor/oc-000-oc-060-audit [07/21] Record OC-000 and OC-060 supervisor audit Jun 14, 2026
@cjohnsto-nz cjohnsto-nz changed the title [07/21] Record OC-000 and OC-060 supervisor audit [07/27] Record OC-000 and OC-060 supervisor audit Jun 15, 2026
@cjohnsto-nz cjohnsto-nz changed the title [07/27] Record OC-000 and OC-060 supervisor audit [07/36] Record OC-000 and OC-060 supervisor audit Jun 15, 2026
@APKiwi

APKiwi commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Verdict: approve. Docs plus packaging hygiene, and the .vscodeignore exclusions (.agents, .github, .opencode, .socket, .windsurf, gap-analysis docs) are sound, dev-coordination dirs should not ship in the VSIX. The audit's build/test/install numbers are self-reported and unverifiable from the diff, but nothing contradicts the stack. One structural note that applies to all the audit PRs: every commit hash cited in the ledger is already unresolvable after GitButler restacks, so the evidence pointers are dead on arrival. Consider citing branch + file paths instead of hashes.

@cjohnsto-nz

Copy link
Copy Markdown
Owner Author

Not changing this audit PR.

The ledger is a contemporaneous coordination log, not a permanent source permalink. Its entries already retain the owning full branch names and test/file paths alongside the then-current GitButler hashes. Rewriting historical entries after every restack would create documentation churn throughout the stack while still becoming stale on the next restack.

The structural point is valid, so the review workflow is now concrete for the remaining PRs: every later-fix claim will cite the stable PR URL/number, full owning branch, and relevant source or task path, with the current remote commit hash included only as supporting evidence after live verification. A mutable hash will no longer be the sole pointer.

The packaging change itself remains correct and requires no rework. PR #41 and immediate child PR #42 are currently MERGEABLE/CLEAN, and PR #41’s build and security checks are successful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants