[08/36] Require demo server fixtures for parallel tracks - #42
Open
cjohnsto-nz wants to merge 1 commit into
Open
Conversation
This was referenced Jun 14, 2026
cjohnsto-nz
force-pushed
the
supervisor/oc-000-oc-060-audit
branch
from
June 14, 2026 22:46
c4c463b to
403e8cc
Compare
cjohnsto-nz
force-pushed
the
supervisor/demo-server-fixtures
branch
from
June 14, 2026 22:46
425dd02 to
c952c56
Compare
cjohnsto-nz
force-pushed
the
supervisor/oc-000-oc-060-audit
branch
from
June 14, 2026 22:49
403e8cc to
ebff346
Compare
cjohnsto-nz
force-pushed
the
supervisor/demo-server-fixtures
branch
from
June 14, 2026 22:49
c952c56 to
4f1fcd0
Compare
cjohnsto-nz
force-pushed
the
supervisor/oc-000-oc-060-audit
branch
from
June 14, 2026 22:50
ebff346 to
25b9a47
Compare
cjohnsto-nz
force-pushed
the
supervisor/demo-server-fixtures
branch
from
June 14, 2026 22:50
4f1fcd0 to
87be5f7
Compare
Collaborator
|
Verdict: approve. The fixture skill encodes the right mandate (bind 127.0.0.1, deterministic ports and payloads, no external services, no internet dependence) and the GraphQL PR downstream actually complies with it. It's guidance-only with no enforcement, but in practice it held. |
Owner
Author
|
Not changing this. PR #42 is intentionally a guidance and acceptance-criteria change; duplicating fixture enforcement inside a Markdown skill would not create an executable guarantee. The enforcement belongs to the implementation branches and their automated tests. At the current remote heads:
PR #42 and its immediate child PR #43 are both currently |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part 14 of 21 in a stack made with GitButler: