Skip to content

[08/36] Require demo server fixtures for parallel tracks - #42

Open
cjohnsto-nz wants to merge 1 commit into
supervisor/oc-000-oc-060-auditfrom
supervisor/demo-server-fixtures
Open

[08/36] Require demo server fixtures for parallel tracks#42
cjohnsto-nz wants to merge 1 commit into
supervisor/oc-000-oc-060-auditfrom
supervisor/demo-server-fixtures

Conversation

@cjohnsto-nz

@cjohnsto-nz cjohnsto-nz commented Jun 14, 2026

Copy link
Copy Markdown
Owner

@cjohnsto-nz
cjohnsto-nz force-pushed the supervisor/oc-000-oc-060-audit branch from c4c463b to 403e8cc Compare June 14, 2026 22:46
@cjohnsto-nz
cjohnsto-nz force-pushed the supervisor/demo-server-fixtures branch from 425dd02 to c952c56 Compare June 14, 2026 22:46
@cjohnsto-nz
cjohnsto-nz force-pushed the supervisor/oc-000-oc-060-audit branch from 403e8cc to ebff346 Compare June 14, 2026 22:49
@cjohnsto-nz
cjohnsto-nz force-pushed the supervisor/demo-server-fixtures branch from c952c56 to 4f1fcd0 Compare June 14, 2026 22:49
@cjohnsto-nz
cjohnsto-nz force-pushed the supervisor/oc-000-oc-060-audit branch from ebff346 to 25b9a47 Compare June 14, 2026 22:50
@cjohnsto-nz
cjohnsto-nz force-pushed the supervisor/demo-server-fixtures branch from 4f1fcd0 to 87be5f7 Compare June 14, 2026 22:50
@cjohnsto-nz cjohnsto-nz changed the title Require demo server fixtures for parallel tracks [08/21] Require demo server fixtures for parallel tracks Jun 14, 2026
@cjohnsto-nz cjohnsto-nz changed the title [08/21] Require demo server fixtures for parallel tracks [08/27] Require demo server fixtures for parallel tracks Jun 15, 2026
@cjohnsto-nz cjohnsto-nz changed the title [08/27] Require demo server fixtures for parallel tracks [08/36] Require demo server fixtures for parallel tracks Jun 15, 2026
@APKiwi

APKiwi commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Verdict: approve. The fixture skill encodes the right mandate (bind 127.0.0.1, deterministic ports and payloads, no external services, no internet dependence) and the GraphQL PR downstream actually complies with it. It's guidance-only with no enforcement, but in practice it held.

@cjohnsto-nz

Copy link
Copy Markdown
Owner Author

Not changing this. PR #42 is intentionally a guidance and acceptance-criteria change; duplicating fixture enforcement inside a Markdown skill would not create an executable guarantee. The enforcement belongs to the implementation branches and their automated tests.

At the current remote heads:

  • PR [09/36] Add OC-010 GraphQL support #43, feature/oc-010-graphql-support at 4b199da5084e5a5aeff28108e3ff41230fed443a, provides the local GraphQL fixtures in examples/demo-api/GraphQL/, the server implementation in examples/demo-api/server.js, and executable coverage in test/graphqlSupport.test.ts and test/runtimeExecutionService.test.ts.
  • PR [10/36] Add OC-020 WebSocket support #44, feature/oc-020-websocket-support at 87caf311fc41556af10ba4424b4c34444dd0c50a, provides the local WebSocket fixtures in examples/demo-api/WebSocket/ and executable coverage in test/webSocketSupport.test.ts.

PR #42 and its immediate child PR #43 are both currently MERGEABLE/CLEAN, with all reported checks passing. No code change is required on this branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants