[04/36] Add OC-090 gRPC streaming support - #38
Conversation
5504fbe to
fdeadfe
Compare
6aa428f to
0815220
Compare
fdeadfe to
6cb577c
Compare
0815220 to
8afca3e
Compare
6cb577c to
2c3d58a
Compare
8afca3e to
de9dc3e
Compare
2c3d58a to
c5dbae7
Compare
de9dc3e to
06b8d83
Compare
|
Verdict: approve with nits. Stream lifecycle (settle guard, cancel, cleanup on every exit, partial-data-on-error) is done carefully, no crash or leak found. Two design items to track before this path gets wired to the UI (it isn't yet, nothing constructs GrpcClient outside tests at this point in the stack):
Tests: solid increment (all three modes, partial data + error, mismatch, cancel cleanup, Ajv round-trip). Gaps: cancel and mid-stream error only tested for server-streaming, no deadline test, and the cancelAll assertion is partly tautological since it clears the map synchronously. Deps: none added. |
|
Fixed the branch-owned findings in commit
The remaining design items do not require OC-090 changes:
Validation after the fix: focused gRPC tests pass 15/15, the full suite passes 348/348, GitHub build/security checks pass, and PR #39 remains |
This is part 18 of 21 in a stack made with GitButler: