Queue 2: StrapdownError + ImuSample (breaking API) - #271
Draft
jbrodovsky wants to merge 1 commit into
Draft
Conversation
3 tasks
jbrodovsky
force-pushed
the
v1/02-filter-api
branch
2 times, most recently
from
September 4, 2026 20:45
0d2f7b2 to
1f87290
Compare
…(breaking API) Placeholder so the stacked PR has a diff. Replaced by the implementation. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
jbrodovsky
force-pushed
the
v1/02-filter-api
branch
from
September 4, 2026 21:09
1f87290 to
290dc8b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v1/02-filter-apiv1/01-eskf-fixWhy
#254 and #255 both break
NavigationFilter; doing them separately means touching three filter impls, ~14 doc examples and 139 unit tests twice. Two commits inside one PR.Acceptance criteria
StrapdownError(thiserror) incore/src/error.rs, exportedpredict/updatereturnResult;predicttakes&dyn InputModelso the trait is object-safepanic!/.unwrap()in library codeImuSample { delta_v, delta_theta, dt }+mechanize();ImuSample::from_rateshelperforward()kept as a deprecated wrapperMeasurementModel::get_jacobianalso returnsResultCloses #254
Part of #255
Stacked on
v1/01-eskf-fix(#270) -- review that first; this PR's diff is against it, notmain.Rebase-merge this stack, do not squash: squashing rewrites the base and forces a manual
git rebase --ontoon every branch above it.Queue:
docs/V1_QUEUE.md| Board: https://github.com/users/jbrodovsky/projects/7