Remove unnecessary deps

[zancas]

What

Ten commits that take the workspace's dependency graph from "the zebra node stack, the librustzcash family, and an unmaintained proc-macro" to: reqwest, tokio, serde, sha2, clap, and the zingo sibling crates. The end state, verified by cargo metadata over every member and every edge kind:

• Zero zcash*, zebra*, or librustzcash-family dependencies of any kind (normal, dev, or build) in any workspace member.
• Zero zebra or librustzcash entries in Cargo.lock (about 5,000 lock lines gone), so even this repo's own test builds compile none of it.
• cargo deny check advisories passes with no ignored advisories.
• Consumers of zcash_local_net (the zls and zaino test builds) stop compiling the zebra stack and librustzcash entirely at their next pin bump.

The commits

• Keygen deleted (b68f4d8): --miner-address defaults to the well-known ABANDONART fixture (the same constant the harness has always mined to; its seed is the public BIP-39 test mnemonic, so default-mined regtest funds import into any wallet). An org-wide audit found no programmatic consumers of the launcher, and every human user has wallet software that mints addresses. Removes zcash_keys, zcash_protocol, zcash_transparent, zip32, bip0039, secp256k1, ripemd, and sha2 from the launcher, and three duplicate-version pairs from the lock.
• MinerPool replaces zcash_protocol::PoolType (b09d9c1): dedicated mine-to-pool vocabulary in zingo-consensus beside NetworkType. The borrowed shape never fit (zebrad panics on its Sapling variant) and consumers only ever passed literals. API break: PoolType::ORCHARD-style literals become MinerPool::Orchard at pin bump (six harness crates across zls/zaino).
• zebra_chain via zebra-rpc's re-export + explicit rpc-client feature (7ae0673): drops a workspace version pin and fixes a latent feature-unification bug.
• Hand-rolled JSON-RPC client (05c7dc9): rpc_client::RpcRequestClient, drop-in for the zebra-node-services client (same name, methods, wire format). Requirements pinned by 8 unit tests against a canned server, including the error-envelope-to-Err mapping that readiness polling depends on; validated 15/15 against real zebrad. zebra-node-services deleted.
• zebra-rpc 11.0 (848422c): brings nu6.3 (ironwood) through the conversion and launcher CLI, off by default (the CLI's cascade semantics would otherwise activate it at the nu6_2 height). should_allow_unshielded_coinbase_spends: None preserves prior consensus behavior.
• mod zebra_rpc (8e74e9e): template parsing and proposal assembly equivalent to proposal_block_from_template for every way this repo uses it, with the commitment branch driven by zingo_consensus::ActivationHeights instead of zebra's Network. Proven by a live differential test: byte-for-byte block and hash equality against a real zebrad at heights 2-6, crossing the NU6.1/NU6.2 lockbox activation, and submitting our bytes so the chain itself accepts them.
• The swap (029e93e): generate_blocks and the launcher mine through the new module. Removing zebra's feature unification unmasked undeclared serde/tokio requirements, now stated explicitly.
• External-types allowlist (116bd5a): the new public API's boundary types (reqwest Response/Result, serde_json Error/Value, serde deserialization traits) sanctioned explicitly.
• Oracle deleted (477504b): the zebra-rpc dev-dependency and its differential suite leave, after capturing a Canopy-branch golden fixture. All three commitment-branch cases (NU5+, lockbox activation, Canopy) are pinned offline by zebra_rpc_golden.rs against fixtures recording the oracle's exact outputs: no binary, no dependency. Recapture machinery lives in git history.
• getset removed (232cf9f): the six Getters/CopyGetters structs get hand-written accessors with identical names and signatures (minus Lightwalletd's never-callable _data_dir()). This erases getset and the unmaintained proc-macro-error2 from the lock, so the RUSTSEC-2026-0173 deny ignore is deleted.

Verification

Full workspace suite run locally with all binaries present (zebrad, zainod, zcashd, lightwalletd): integration and e2e green, including real mining through the new client and assembler. cargo check --workspace --all-features, clippy, fmt, and cargo deny clean at every step. Golden regression fixtures in tests/fixtures/zebra_rpc/ pin block-assembly equivalence with zebra-rpc permanently.

Notes for reviewers

• The launcher e2e snapshot changed with the keygen removal (no more mnemonic block in the output).
• CAPTURE_PROPOSAL_FIXTURES=1 refreshed the golden fixtures while the oracle existed; to recapture after a zebra template-format change, resurrect tests/zebra_rpc_oracle.rs and the zebra-rpc dev-dependency from git history. The variable deliberately avoids the ZEBRA_ prefix: zebrad parses ZEBRA_* environment variables as configuration and refuses to launch on unknown fields.
• Remaining follow-up, deliberately not included: CI-image provisioning for zcash-devtool and zainod, to un-filter the five devtool_client integration tests excluded in .config/nextest.toml.

🤖 Generated with Claude Code

[zancas]

I have a branch of zaino that depends on this feature all tests pass there.

[dannywillems]

utACK 232cf9f

I read the Claude text about why the code is duplicated here (for instance PoolType and ActivationHeights), but I don't still understand why it is replaced.

Accepting to move further.