build: point infrastructure deps at remove_unnecessary_deps branch#2431
Open
zancas wants to merge 2 commits into
Open
build: point infrastructure deps at remove_unnecessary_deps branch#2431zancas wants to merge 2 commits into
zancas wants to merge 2 commits into
Conversation
Pin zcash_local_net and zingo_test_vectors to the head of zingolabs/infrastructure#276, which prunes ~130 transitive dependencies (zebra-*, rocksdb, jsonrpsee, bindgen chains) and introduces the zingo-consensus crate. That branch drops the zcash_protocol::PoolType re-export and speaks its own zingo_consensus::{MinerPool, ActivationHeights} types, which are distinct from the zingo_common_components types zingolib uses. Keep the scenario API on the wallet-side vocabulary and convert only at the zcash_local_net boundary: zingolib_testutils::scenarios gains private converters plus a public validator_activation_heights() helper, now used at every call site in zingolib_testutils and libtonode-tests. The reverse heights conversion asserts nu6_3 is unset, since the wallet-side type cannot represent it. Add CONTEXT.md capturing the MinerPool/PoolType and dual ActivationHeights terminology boundary. Re-pin to a release tag once infrastructure#276 merges. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
zancas
force-pushed
the
update_infrastructure_to_cut_deps
branch
from
5708011 to
cf97724
Compare
cargo-make [env] entries unconditionally clobber shell-exported variables, so the help text's documented override (ZINGOLIB_NEXTEST_FILTER='...' makers container-test) never worked. Wrap the ZINGOLIB_NEXTEST_* knobs in env_not_set conditions so a caller-exported value wins and the Makefile default applies otherwise. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Member
Author
|
The good news is that all the tests pass! The bad news is that none of them tests against zebrad. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pin zcash_local_net and zingo_test_vectors to the head of zingolabs/infrastructure#276, which prunes ~130 transitive dependencies (zebra-*, rocksdb, jsonrpsee, bindgen chains) and introduces the zingo-consensus crate.
That branch drops the zcash_protocol::PoolType re-export and speaks its own zingo_consensus::{MinerPool, ActivationHeights} types, which are distinct from the zingo_common_components types zingolib uses. Keep the scenario API on the wallet-side vocabulary and convert only at the zcash_local_net boundary: zingolib_testutils::scenarios gains private converters plus a public validator_activation_heights() helper, now used at every call site in zingolib_testutils and libtonode-tests. The reverse heights conversion asserts nu6_3 is unset, since the wallet-side type cannot represent it.
Add CONTEXT.md capturing the MinerPool/PoolType and dual ActivationHeights terminology boundary.
Re-pin to a release tag once infrastructure#276 merges.