Track upstream librustzcash main and zcashfoundation zebra#274
Closed
dannywillems wants to merge 1 commit into
Closed
Track upstream librustzcash main and zcashfoundation zebra#274dannywillems wants to merge 1 commit into
dannywillems wants to merge 1 commit into
Conversation
Repoint the [patch.crates-io] librustzcash crates at the canonical zcash/librustzcash main (rev eb828ca) and zebra at zcashfoundation/zebra nu63-ironwood, replacing the zingolabs forks. Bump the workspace version requirements (zebra-chain 10.1.0, zebra-node-services 8.0.0, zebra-rpc 10.0.1, zcash_protocol 0.10.0-pre.0) so the patches actually apply. Without a matching SemVer requirement the patches were silently ignored and the older crates.io versions were compiled, which lacked the NU6.3 additions. Adapt to upstream API changes: - zcash_protocol gained ShieldedPool::Ironwood; handle PoolType::IRONWOOD in the zcashd and zebrad mine-to-pool matches. It is unsupported (no regtest Ironwood miner address), matching the existing panic style for pools that cannot be mined to. - zebra RegtestParameters gained should_allow_unshielded_coinbase_spends; set it to None to preserve current behaviour. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Member
|
Superseded by #276 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repoint the [patch.crates-io] librustzcash crates at the canonical zcash/librustzcash main (rev eb828ca) and zebra at zcashfoundation/zebra nu63-ironwood, replacing the zingolabs forks.
Bump the workspace version requirements (zebra-chain 10.1.0, zebra-node-services 8.0.0, zebra-rpc 10.0.1, zcash_protocol 0.10.0-pre.0) so the patches actually apply. Without a matching SemVer requirement the patches were silently ignored and the older crates.io versions were compiled, which lacked the NU6.3 additions.
Adapt to upstream API changes: