Skip to content

[Core] DrawMesh<Hexahedron>: add quick test for quads when drawing hexa #6152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fredroy wants to merge 2 commits into
base: master
Choose a base branch
from
+22 −0
Open

[Core] DrawMesh<Hexahedron>: add quick test for quads when drawing hexa #6152

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73ead5c
add quick test for quads when drawing hexa
fredroy Jun 15, 2026
83673ff
add tests for triangles/tetra too
fredroy Jun 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions Sofa/framework/Core/src/sofa/core/visual/DrawMesh.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,6 +328,17 @@ struct SOFA_CORE_API DrawElementMesh<sofa::geometry::Tetrahedron>
const auto& elements = topology->getTetrahedra();
const auto& facets = topology->getTriangles();

if(facets.empty())
{
static bool firstTime = true;
if (firstTime)
{
msg_error("DrawElementMesh<Tetrahedron>") << "Drawing tetrahedra needs the associated triangles in the topology.";
firstTime = false;
}
return;
}

for ( auto& p : renderedPoints)
{
p.resize(elementIndices.size() * sofa::geometry::Triangle::NumberOfNodes);
Expand Down Expand Up @@ -474,6 +485,17 @@ struct SOFA_CORE_API DrawElementMesh<sofa::geometry::Hexahedron>
const auto& elements = topology->getHexahedra();
const auto& facets = topology->getQuads();

if(facets.empty())
{
static bool firstTime = true;
if (firstTime)
{
msg_error("DrawElementMesh<Hexahedron>") << "Drawing hexahedra needs the associated quads in the topology.";
firstTime = false;
}
return;
}

for ( auto& p : renderedPoints)
{
p.resize(elementIndices.size() * sofa::geometry::Quad::NumberOfNodes);
Expand Down
Loading