Skip to content

Add Windows export settings for laser_filters #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tobias-Fischer wants to merge 1 commit into
base: rolling
Choose a base branch
from
Open

Add Windows export settings for laser_filters #262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,11 @@ ament_auto_add_library(laser_filter_chains SHARED
src/scan_to_cloud_filter_chain.cpp
src/scan_to_scan_filter_chain.cpp)

if(WIN32)
set_target_properties(laser_scan_filters PROPERTIES WINDOWS_EXPORT_ALL_SYMBOLS ON)
set_target_properties(laser_filter_chains PROPERTIES WINDOWS_EXPORT_ALL_SYMBOLS ON)
endif()

# The rclcpp_components_register_node macro registers an rclcpp component for the node with
# the ament resource index AND creates a templated executable that spins the given node.

Expand Down
2 changes: 1 addition & 1 deletion include/laser_filters/binning_filter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ class LaserScanBinningFilter : public filters::FilterBase<sensor_msgs::msg::Lase
{
public:

uint num_bins_;
unsigned int num_bins_;

bool configure()
{
Expand Down
Loading