Add Windows export settings for laser_filters - #262
Open
Tobias-Fischer wants to merge 1 commit into
Open
Conversation
Author
|
FYI @wep21 and @traversaro, this upstream PR comes from the RoboStack patch upstreaming tracker: RoboStack/robostack.github.io#16. Origin patch: RoboStack |
|
Tick the box to add this pull request to the merge queue (same as
|
Contributor
|
Thanks for this! I'll take a look at it this week. |
Tobias-Fischer
force-pushed
the
codex/robostack-rolling-laser-filters-windows-exports
branch
from
July 20, 2026 01:11
91df8c5 to
a24ef35
Compare
This upstreams RoboStack downstream patch `patch/ros-rolling-laser-filters.win.patch`. Best-guess rationale: the laser_filters shared libraries need exported symbols on Windows, and the scan binning filter should avoid the non-standard uint typedef for better compiler portability. The original downstream patch also linked Boost thread for older code, but upstream removed the remaining Boost recursive mutex usage in ros-perception#209, so this upstream PR no longer needs to add any Boost dependency. Signed-off-by: Tobias Fischer <info@tobiasfischer.info>
Tobias-Fischer
force-pushed
the
codex/robostack-rolling-laser-filters-windows-exports
branch
from
July 20, 2026 01:17
a24ef35 to
ed5f5b7
Compare
Contributor
|
The changes in this PR look good to me. I think the test failure on rolling is unrelated, but I need to take some time to debug that before merging this. Rolling recently updated to 26.04; I suspect the test failure is related to that.... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of an effort to contribute RoboStack downstream patches back upstream.
Origin: RoboStack
patch/ros-rolling-laser-filters.win.patch, authored by Daisuke Nishimatsu.Best-guess rationale: the laser_filters shared libraries need exported symbols on Windows, and the scan binning filter should avoid the non-standard uint typedef for better compiler portability.