Fix wrench transformer namespace test flake - #2492
Merged
christophfroehlich merged 1 commit intoJul 29, 2026
Merged
Conversation
Signed-off-by: Dennis Lanov <dennis.lanov@gmail.com>
github-actions
Bot
requested review from
bijoua29,
christophfroehlich,
erickisos,
saikishor and
xguay
July 28, 2026 20:24
saikishor
reviewed
Jul 29, 2026
| { | ||
| for (int attempts = 0; attempts < max_attempts; ++attempts) | ||
| { | ||
| if (check_publisher_exists_via_graph(node, topic_name)) |
Member
There was a problem hiding this comment.
Is this API compatible on Humble?
Let's see what the CI says
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2492 +/- ##
==========================================
+ Coverage 86.83% 86.85% +0.01%
==========================================
Files 148 148
Lines 16273 16267 -6
Branches 1368 1367 -1
==========================================
- Hits 14131 14128 -3
+ Misses 1635 1632 -3
Partials 507 507
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
saikishor
approved these changes
Jul 29, 2026
christophfroehlich
merged commit Jul 29, 2026
be6f504
into
ros-controls:master
27 of 31 checks passed
This was referenced Jul 29, 2026
christophfroehlich
pushed a commit
that referenced
this pull request
Jul 29, 2026
christophfroehlich
pushed a commit
that referenced
this pull request
Jul 29, 2026
christophfroehlich
pushed a commit
that referenced
this pull request
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the flaky wrench transformer namespace tests by replacing timing-sensitive, one-shot ROS graph checks with bounded polling.
Changes
Testing
colcon build --symlink-install --packages-up-to force_torque_sensor_broadcaster --cmake-args -DBUILD_TESTING=ONcolcon test --packages-select force_torque_sensor_broadcaster --event-handlers console_cohesion+colcon test-result --verboseRepeated both namespace tests 100 times:
TestWrenchTransformer.NamespaceNormalizationRootNamespaceTestWrenchTransformer.NamespaceNormalizationCustomNamespacepre-commit run --files force_torque_sensor_broadcaster/test/test_wrench_transformer.cppgit diff --checkResults:
Closes #2487
AI assistance
Claude Code assisted with analyzing and preparing the narrowly scoped test change. I manually reviewed the complete diff and verified the build, package tests, repeated stress tests, formatting, lint, and whitespace-check results.