Fix wrench transformer namespace test flake (backport #2492) - #2495
Merged
Conversation
(cherry picked from commit be6f504)
Contributor
Author
|
Tick the box to add this pull request to the merge queue (same as
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## kilted #2495 +/- ##
==========================================
- Coverage 86.92% 86.91% -0.02%
==========================================
Files 156 156
Lines 15583 15577 -6
Branches 1340 1339 -1
==========================================
- Hits 13545 13538 -7
- Misses 1568 1571 +3
+ Partials 470 468 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the flaky wrench transformer namespace tests by replacing timing-sensitive, one-shot ROS graph checks with bounded polling.
Changes
Testing
colcon build --symlink-install --packages-up-to force_torque_sensor_broadcaster --cmake-args -DBUILD_TESTING=ONcolcon test --packages-select force_torque_sensor_broadcaster --event-handlers console_cohesion+colcon test-result --verboseRepeated both namespace tests 100 times:
TestWrenchTransformer.NamespaceNormalizationRootNamespaceTestWrenchTransformer.NamespaceNormalizationCustomNamespacepre-commit run --files force_torque_sensor_broadcaster/test/test_wrench_transformer.cppgit diff --checkResults:
Closes #2487
AI assistance
Claude Code assisted with analyzing and preparing the narrowly scoped test change. I manually reviewed the complete diff and verified the build, package tests, repeated stress tests, formatting, lint, and whitespace-check results.
This is an automatic backport of pull request #2492 done by [Mergify](https://mergify.com).