Art-Net・DMX関連を実装とチュートリアルの削除 by otoyuzu705 · Pull Request #3 · otoyuzu705/LightVisualizer

otoyuzu705 · 2026-03-11T23:27:42Z

Art-Net受信用コンポーネント
Assets/Core/Network/ArtNetReceiver.cs

DMXチャンネルの管理用クラス
Assets/Core/Network/DmxBuffer.cs

DMXチャンネルの値をグリッド形式で視覚化するエディターツール
Assets/Editor/Windows/DmxMonitorWindow.cs

Unity標準のTutorialInfoを削除

Copilot

Pull request overview

This PR removes Unity HDRP template/tutorial “Readme” assets and introduces an Art-Net DMX receive pipeline with an Editor DMX monitoring window, plus small scene/settings updates to support it.

Changes:

Removed Assets/TutorialInfo/* readme/editor/layout assets from the Unity template.
Added Core.Network.ArtNetReceiver + DmxBuffer and placed an ArtNetReceiver GameObject into OutdoorsScene.
Added an EditorWindow (DmxMonitorWindow) to visualize DMX values during Play Mode; adjusted sky/fog profile parameters.

Reviewed changes

Copilot reviewed 20 out of 23 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
LightVisualizer/Assets/TutorialInfo/Scripts/Readme.cs.meta	Removes template readme script meta.
LightVisualizer/Assets/TutorialInfo/Scripts/Readme.cs	Removes template `Readme` ScriptableObject type.
LightVisualizer/Assets/TutorialInfo/Scripts/Editor/ReadmeEditor.cs.meta	Removes template custom editor meta.
LightVisualizer/Assets/TutorialInfo/Scripts/Editor/ReadmeEditor.cs	Removes template readme inspector/auto-layout editor script.
LightVisualizer/Assets/TutorialInfo/Layout.wlt.meta	Removes template layout meta.
LightVisualizer/Assets/TutorialInfo/Layout.wlt	Removes template editor layout.
LightVisualizer/Assets/TutorialInfo/Icons/Help_Icon.png.meta	Removes template icon meta.
LightVisualizer/Assets/TutorialInfo/Icons/HDRP.png.meta	Removes template icon meta.
LightVisualizer/Assets/Settings/SkyandFogSettingsProfile.asset	Updates HDRP sky/fog profile parameters.
LightVisualizer/Assets/OutdoorsScene.unity	Adds an `ArtNetReceiver` GameObject to the scene.
LightVisualizer/Assets/Editor/Windows/DmxMonitorWindow.cs.meta	Adds meta for the DMX monitor editor window script.
LightVisualizer/Assets/Editor/Windows/DmxMonitorWindow.cs	Adds an EditorWindow to display DMX channels in Play Mode.
LightVisualizer/Assets/Editor/Windows.meta	Folder meta update for `Assets/Editor/Windows`.
LightVisualizer/Assets/Editor.meta	Folder meta update for `Assets/Editor`.
LightVisualizer/Assets/Core/Network/DmxBuffer.cs.meta	Adds meta for the DMX buffer script.
LightVisualizer/Assets/Core/Network/DmxBuffer.cs	Adds buffer/storage for multi-universe DMX data with locking.
LightVisualizer/Assets/Core/Network/ArtNetReceiver.cs.meta	Adds meta for the Art-Net receiver script.
LightVisualizer/Assets/Core/Network/ArtNetReceiver.cs	Adds UDP Art-Net receive thread and DMX packet parsing.
LightVisualizer/Assets/Core/Network.meta	Folder meta update for `Assets/Core/Network`.
LightVisualizer/Assets/Core.meta	Folder meta update for `Assets/Core`.
LightVisualizer/.idea/.idea.LightVisualizer/.idea/copilot.data.migration.ask2agent.xml	Adds IDE state/config related to Copilot migration.

Files not reviewed (1)

LightVisualizer/.idea/.idea.LightVisualizer/.idea/copilot.data.migration.ask2agent.xml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-11T23:45:57Z

+        private void ProcessPacket(byte[] data)
+        {
+            if (data == null) return;
+
+            // ヘッダーの検証
+            for (int i = 0; i < 8; i++)
+            {
+                if (data[i] != _artNetHeader[i]) return; 
+            }
+
+            // OpCodeの検証
+            ushort opCode = BitConverter.ToUInt16(data, 8);
+            if (opCode != 0x5000) return; // ArtDMXパケットのみ処理
+
+            // ユニバースの計算
+            int universe = data[14] | (data[15] << 8);
+
+            int length = (data[16] << 8) | data[17];
+            if (length > 512) return; 
+
+            // DMXデータの更新
+            byte[] dmxData = new byte[length];
+            Buffer.BlockCopy(data, 18, dmxData, 0, length);
+


ProcessPacket reads fixed offsets (0..17) and copies from offset 18 without first validating data.Length. A short/invalid UDP packet will cause IndexOutOfRangeException or ArgumentException during BlockCopy. Add minimum-length checks (and ensure data.Length >= 18 + length) before accessing these indices.

@copilot open a new pull request to apply changes based on this feedback

Copilot · 2026-03-11T23:45:57Z

+                {
+                    int index = startIndex + row * columns + col;
+                    byte value = index < dmxData.Length ? dmxData[index] : (byte)0;
+
+                    GUIStyle cellStyle = new GUIStyle(GUI.skin.box)
+                    {
+                        fixedWidth = 30,
+                        fixedHeight = 30,
+                        alignment = TextAnchor.MiddleCenter,
+                    };
+                    cellStyle.normal.textColor = Color.white;


DrawDmxGrid allocates a new GUIStyle for every cell on every repaint (512 allocations per universe per frame), which will create avoidable GC churn in the Editor. Cache/reuse a single cell style (or a small set of styles) instead of constructing it inside the inner loop.

Copilot · 2026-03-11T23:45:57Z

+            // DMXデータを取得
+            byte[] dmxData = receiver.DmxBuffer.GetDmxDataSnapshot();
+
+            // 選択されたユニバースの開始インデックス
+            int startIndex = _selectedUniverse * DmxBuffer.ChannelsPerUniverse;
+
+            DrawDmxGrid(dmxData, startIndex);


GetDmxDataSnapshot() allocates a full copy of the DMX buffer each OnGUI call; combined with Repaint() every frame this can generate steady GC pressure. Consider returning a reused buffer, a per-universe snapshot, or exposing a read-only view with locking so the window can render without allocating every frame.

Copilot · 2026-03-11T23:45:57Z

+            // ヘッダー行の描画
+            EditorGUILayout.BeginHorizontal();
+            for (int col = 0; col < columns; col++)
+            {
+                GUILayout.Label($"Column {col + 1}", EditorStyles.centeredGreyMiniLabel, GUILayout.Width(30));
+            }
+            EditorGUILayout.EndHorizontal();
+
+            // DMXチャンネルの描画
+            for (int row = 0; row < rows; row++)
+            {
+                EditorGUILayout.BeginHorizontal();
+
+                // 行の先頭チャンネル番号
+                int startChannel = row * columns + 1;
+                GUILayout.Label($"{startChannel:000}", EditorStyles.boldLabel, GUILayout.Width(40));
+


The header row draws 32 column labels, but each data row also renders an extra leading channel-number label, causing the grid to be visually misaligned. Add an empty/header cell (matching the 40px width) or otherwise account for the row-label column so columns line up.

@copilot open a new pull request to apply changes based on this feedback

Copilot · 2026-03-11T23:45:58Z

+        private void Awake()
+        {
+            this.DmxBuffer = new DmxBuffer();
+        }
+


This PR removes the Readme ScriptableObject script and HDRP tutorial icon assets, but Assets/Readme.asset still references the deleted script GUID (fcf7219...) and icon GUID (d19680...). This will produce a missing-script asset on import. Either delete Assets/Readme.asset or update it to a remaining script/icon.

@copilot open a new pull request to apply changes based on this feedback

Copilot · 2026-03-11T23:45:58Z

+<?xml version="1.0" encoding="UTF-8"?>
+<project version="4">
+  <component name="Ask2AgentMigrationStateService">
+    <option name="migrationStatus" value="COMPLETED" />
+  </component>
+</project>


copilot.data.migration.ask2agent.xml looks like a local JetBrains/Rider state file rather than project source. Consider adding it to the appropriate .idea/.gitignore (or repo root .gitignore) and removing it from version control to avoid churn across developers.

@copilot open a new pull request to apply changes based on this feedback

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot · 2026-03-13T02:50:55Z

@otoyuzu705 I've opened a new pull request, #4, to work on those changes. Once the pull request is ready, I'll request review from you.

…angeException Co-authored-by: otoyuzu705 <107416827+otoyuzu705@users.noreply.github.com>

Guard ProcessPacket against short/malformed UDP packets

Copilot · 2026-03-13T03:15:12Z

@otoyuzu705 I've opened a new pull request, #5, to work on those changes. Once the pull request is ready, I'll request review from you.

…add to .gitignore Co-authored-by: otoyuzu705 <107416827+otoyuzu705@users.noreply.github.com>

Copilot · 2026-03-13T03:18:16Z

@otoyuzu705 I've opened a new pull request, #6, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: otoyuzu705 <107416827+otoyuzu705@users.noreply.github.com>

Copilot · 2026-03-13T03:19:30Z

@otoyuzu705 I've opened a new pull request, #7, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: otoyuzu705 <107416827+otoyuzu705@users.noreply.github.com>

Remove JetBrains Rider local state file from version control

Delete Readme.asset with dangling GUID references

Fix DMX monitor grid header misalignment

otoyuzu705 added 6 commits March 11, 2026 13:48

DMX管理用クラスとArt-Net受信用のモジュールを作成

5d7e93a

DMXモニターの実装

ef1859f

ArtNerReceiverを探す処理で使用しているメソッドを変更

5a6f1ee

Art-Net受信処理の開始と停止を追加

94d98a8

DMXモニターの描画処理の呼び出しを追加

bb325ad

DMXモニターのUIを修正

7fb9daf

otoyuzu705 changed the title ~~Art-Net/関連を実装~~ Art-Net・DMX関連を実装 Mar 11, 2026

otoyuzu705 changed the title ~~Art-Net・DMX関連を実装~~ Art-Net・DMX関連を実装とチュートリアルの削除 Mar 11, 2026

otoyuzu705 requested a review from Copilot March 11, 2026 23:41

Copilot started reviewing on behalf of otoyuzu705 March 11, 2026 23:41 View session

Copilot AI reviewed Mar 11, 2026

View reviewed changes

otoyuzu705 and others added 3 commits March 12, 2026 08:49

Update LightVisualizer/Assets/Core/Network/ArtNetReceiver.cs

a776e45

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update LightVisualizer/Assets/Core/Network/DmxBuffer.cs

d6328d9

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Initial plan

9a91404

Copilot AI mentioned this pull request Mar 13, 2026

Guard ProcessPacket against short/malformed UDP packets #4

Merged

Copilot AI and others added 3 commits March 13, 2026 02:53

Add minimum-length validation in ProcessPacket to prevent IndexOutOfR…

c881e74

…angeException Co-authored-by: otoyuzu705 <107416827+otoyuzu705@users.noreply.github.com>

Merge pull request #4 from otoyuzu705/copilot/sub-pr-3

2fe30eb

Guard ProcessPacket against short/malformed UDP packets

Initial plan

944f960

Copilot AI mentioned this pull request Mar 13, 2026

Remove JetBrains Rider local state file from version control #5

Merged

Copilot AI and others added 2 commits March 13, 2026 03:16

Remove copilot.data.migration.ask2agent.xml from version control and …

9ebfae0

…add to .gitignore Co-authored-by: otoyuzu705 <107416827+otoyuzu705@users.noreply.github.com>

Initial plan

635457a

Copilot AI mentioned this pull request Mar 13, 2026

Delete Readme.asset with dangling GUID references #6

Merged

Copilot AI and others added 2 commits March 13, 2026 03:19

Initial plan

73e7672

Delete Readme.asset to fix missing-script asset warning

7361bba

Co-authored-by: otoyuzu705 <107416827+otoyuzu705@users.noreply.github.com>

Copilot AI mentioned this pull request Mar 13, 2026

Fix DMX monitor grid header misalignment #7

Merged

Fix header row misalignment in DmxMonitorWindow by adding 40px spacer

c886b25

Co-authored-by: otoyuzu705 <107416827+otoyuzu705@users.noreply.github.com>

otoyuzu705 added 3 commits March 13, 2026 12:39

Merge pull request #5 from otoyuzu705/copilot/sub-pr-3

4d49f57

Remove JetBrains Rider local state file from version control

Merge pull request #6 from otoyuzu705/copilot/sub-pr-3-again

06fbf6c

Delete Readme.asset with dangling GUID references

Merge pull request #7 from otoyuzu705/copilot/sub-pr-3-another-one

72830f3

Fix DMX monitor grid header misalignment

otoyuzu705 merged commit f521990 into dev Mar 13, 2026

otoyuzu705 deleted the feat/art-net branch March 13, 2026 03:46

Conversation

otoyuzu705 commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

otoyuzu705 Mar 13, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

otoyuzu705 Mar 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

otoyuzu705 Mar 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

otoyuzu705 Mar 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Mar 13, 2026

Uh oh!

Copilot AI commented Mar 13, 2026

Uh oh!

Copilot AI commented Mar 13, 2026

Uh oh!

Copilot AI commented Mar 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

otoyuzu705 commented Mar 11, 2026 •

edited

Loading