Guard ProcessPacket against short/malformed UDP packets - #4
Merged
Conversation
…angeException Co-authored-by: otoyuzu705 <107416827+otoyuzu705@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on Art-Net・DMX implementation and tutorial removal
Guard ProcessPacket against short/malformed UDP packets
Mar 13, 2026
otoyuzu705
marked this pull request as ready for review
March 13, 2026 03:08
Owner
|
@copilot |
Contributor
Author
了解しました。今後のコメントは日本語で記載します。なお、今回追加したコードコメントはすでに日本語で記載しています(例: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ProcessPacketaccessed fixed byte offsets 0–17 and calledBuffer.BlockCopyfrom offset 18 without validatingdata.Length, causingIndexOutOfRangeExceptionorArgumentExceptionon any short or malformed UDP packet.Changes
if (data.Length < 18) return;added immediately after the null guard, before any index accessif (data.Length < 18 + length) return;added after extractinglength, preventingBlockCopyfrom reading past the buffer endlength < 0 || length > 512to be explicit about both bounds💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.