Skip to content

Fix DMX monitor grid header misalignment - #7

Merged
otoyuzu705 merged 2 commits into
feat/art-netfrom
copilot/sub-pr-3-another-one
Mar 13, 2026
Merged

Fix DMX monitor grid header misalignment#7
otoyuzu705 merged 2 commits into
feat/art-netfrom
copilot/sub-pr-3-another-one

Conversation

Copilot AI commented Mar 13, 2026

Copy link
Copy Markdown
Contributor

The header row in DmxMonitorWindow rendered 32 column labels without accounting for the 40px row-label (channel number) at the start of each data row, causing headers to be offset by one column.

Change

Added a 40px empty spacer as the first element of the header row to match the row-label width in data rows:

// Before
EditorGUILayout.BeginHorizontal();
for (int col = 0; col < columns; col++)
    GUILayout.Label($"Column {col + 1}", ..., GUILayout.Width(30));
EditorGUILayout.EndHorizontal();

// After
EditorGUILayout.BeginHorizontal();
GUILayout.Label("", GUILayout.Width(40)); // 行ラベル列のスペーサー
for (int col = 0; col < columns; col++)
    GUILayout.Label($"Column {col + 1}", ..., GUILayout.Width(30));
EditorGUILayout.EndHorizontal();

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

Co-authored-by: otoyuzu705 <107416827+otoyuzu705@users.noreply.github.com>
Copilot AI changed the title [WIP] [WIP] Address feedback on Art-Net・DMX implementation Fix DMX monitor grid header misalignment Mar 13, 2026
Copilot AI requested a review from otoyuzu705 March 13, 2026 03:22
@otoyuzu705
otoyuzu705 marked this pull request as ready for review March 13, 2026 03:42

@otoyuzu705 otoyuzu705 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@otoyuzu705
otoyuzu705 merged commit 72830f3 into feat/art-net Mar 13, 2026
@otoyuzu705
otoyuzu705 deleted the copilot/sub-pr-3-another-one branch March 13, 2026 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants