Stop collecting a Google Pay billing address by default (breaking) - #71
Merged
Max Harrison (maxharrison) merged 0 commit intoAug 20, 2026
Conversation
Max Harrison (maxharrison)
force-pushed
the
max/gpay-billing-address-default
branch
from
August 20, 2026 16:02
cea2ca0 to
8d2f6e6
Compare
Max Harrison (maxharrison)
merged commit Aug 20, 2026
8d2f6e6
into
max/gpay-golden-requests
1 check passed
Max Harrison (maxharrison)
force-pushed
the
max/gpay-golden-requests
branch
from
August 20, 2026 16:02
3123efe to
6bc8081
Compare
Max Harrison (maxharrison)
deleted the
max/gpay-billing-address-default
branch
August 20, 2026 16:02
Contributor
Author
|
Reopened as #72 after the stack was reordered. GitHub auto-closed this one as merged into its former stack base; nothing landed on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #70. Review that first.
Breaking change. Do not merge before a major Android SDK release.
Config.billingAddressnow defaults toBillingAddressConfig.Disabledinstead ofBillingAddressConfig.Enabled().Merchants who relied on the implicit billing address request must now opt in:
Why
Collecting a billing address that the integrator never asked for is the wrong default for a payments SDK. The web SDK has always treated it as opt-in, so Android is the outlier.
Risk
A merchant who uses the billing address for AVS or for fraud rules loses that data on upgrade, with no error and no compile failure. That can move authorisation rates. A release note is the only signal, which is why this waits for a major version rather than riding a minor.
What changes
Config.billingAddressdefault.PaymentRequestTestsplits the old default assertion into a default case and an explicitly enabled case.GooglePayGoldenRequestTestpoints the default case at thebilling-disabledfixture. That one-line diff is the whole behaviour change, which is the point of landing the goldens first.