Skip to content

Stop collecting a Google Pay billing address by default (breaking) - #71

Merged
Max Harrison (maxharrison) merged 0 commit into
max/gpay-golden-requestsfrom
max/gpay-billing-address-default
Aug 20, 2026
Merged

Stop collecting a Google Pay billing address by default (breaking)#71
Max Harrison (maxharrison) merged 0 commit into
max/gpay-golden-requestsfrom
max/gpay-billing-address-default

Conversation

@maxharrison

Copy link
Copy Markdown
Contributor

Stacked on #70. Review that first.

Breaking change. Do not merge before a major Android SDK release.

Config.billingAddress now defaults to BillingAddressConfig.Disabled instead of BillingAddressConfig.Enabled().

Merchants who relied on the implicit billing address request must now opt in:

Config(
    appId = appId,
    merchantId = merchantId,
    billingAddress = BillingAddressConfig.Enabled(),
)

Why

Collecting a billing address that the integrator never asked for is the wrong default for a payments SDK. The web SDK has always treated it as opt-in, so Android is the outlier.

Risk

A merchant who uses the billing address for AVS or for fraud rules loses that data on upgrade, with no error and no compile failure. That can move authorisation rates. A release note is the only signal, which is why this waits for a major version rather than riding a minor.

What changes

  • Config.billingAddress default.
  • PaymentRequestTest splits the old default assertion into a default case and an explicitly enabled case.
  • GooglePayGoldenRequestTest points the default case at the billing-disabled fixture. That one-line diff is the whole behaviour change, which is the point of landing the goldens first.

@maxharrison
Max Harrison (maxharrison) requested a review from a team as a code owner August 20, 2026 15:53
@maxharrison
Max Harrison (maxharrison) force-pushed the max/gpay-billing-address-default branch from cea2ca0 to 8d2f6e6 Compare August 20, 2026 16:02
@maxharrison
Max Harrison (maxharrison) merged commit 8d2f6e6 into max/gpay-golden-requests Aug 20, 2026
1 check passed
@maxharrison
Max Harrison (maxharrison) deleted the max/gpay-billing-address-default branch August 20, 2026 16:02
@maxharrison

Copy link
Copy Markdown
Contributor Author

Reopened as #72 after the stack was reordered. GitHub auto-closed this one as merged into its former stack base; nothing landed on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant