Stop collecting a Google Pay billing address by default (breaking) - #72
Draft
Max Harrison (maxharrison) wants to merge 2 commits into
Draft
Stop collecting a Google Pay billing address by default (breaking)#72Max Harrison (maxharrison) wants to merge 2 commits into
Max Harrison (maxharrison) wants to merge 2 commits into
Conversation
BREAKING CHANGE: Config.billingAddress now defaults to BillingAddressConfig.Disabled. Merchants who relied on the implicit billing address request must set billingAddress = BillingAddressConfig.Enabled() to keep it. This matches the web SDK, where billing address collection has always been opt-in. Collecting an address that the integrator never asked for is the wrong default for a payments SDK. Merchants who use the billing address for AVS or fraud rules lose that data silently on upgrade, so hold this until the next major Android SDK release.
This was referenced Aug 20, 2026
Google Pay omits paymentMethodData.info.billingAddress when address collection is disabled. Read that field as optional so successful payments without an address do not produce an error log. Rename the extraction helper to reflect that it parses the whole billing address, not only the name.
Jake Grogan (jakekgrog)
approved these changes
Aug 21, 2026
ana-maksimovskikh
approved these changes
Aug 24, 2026
ana-maksimovskikh
left a comment
ana-maksimovskikh
left a comment
Contributor
There was a problem hiding this comment.
Looks good, thanks Max!
Contributor
Author
|
happy to merge, but blocking this for now as its the breaking change that we will wait for the major release |
Max Harrison (maxharrison)
marked this pull request as draft
August 24, 2026 10:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Config.billingAddressdefaulted toBillingAddressConfig.Enabled(), so Android collected a billing address unless the merchant opted out. It now defaults toBillingAddressConfig.Disabled, matching the web SDK's opt-in behaviour.Google Pay omits
paymentMethodData.info.billingAddresswhen collection is disabled. The response parser now treats that field as optional, so a normal payment without an address does not produce an error log.This is a breaking change. Merchants that need billing data for AVS or fraud rules must set
billingAddress = BillingAddressConfig.Enabled()before upgrading. Hold this PR for the next major Android SDK release.Stack: #70 adds golden request tests on top of this PR.