Skip to content

ci: fix coverage badge push and update actions for Node.js 24 #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anzalks merged 1 commit into from
Jun 13, 2026
+10 −7
Merged

ci: fix coverage badge push and update actions for Node.js 24 #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@ jobs:
- name: Find installer workflow run for this commit
id: installer_run
if: github.event_name == 'push' || (github.event_name == 'workflow_dispatch' && github.event.inputs.dry_run == 'false')
uses: actions/github-script@v7
uses: actions/github-script@v9
with:
script: |
const { owner, repo } = context.repo;
Expand Down Expand Up @@ -391,14 +391,14 @@ jobs:
echo "notes_file=release_notes.md" >> "$GITHUB_OUTPUT"

- name: Create or update GitHub Release
# softprops/action-gh-release@v2 creates the release if it does not exist
# softprops/action-gh-release@v3 creates the release if it does not exist
# and updates (appends files to) the release if it was already created by
# the installer.yml workflow running in parallel. The old
# "gh release delete + recreate" pattern was destructive: it wiped any
# .exe / .dmg binaries that installer.yml had already attached, because
# both workflows fire in parallel on the same tag push.
if: github.event_name == 'push' || (github.event_name == 'workflow_dispatch' && github.event.inputs.dry_run == 'false')
uses: softprops/action-gh-release@v2
uses: softprops/action-gh-release@v3
with:
tag_name: ${{ github.ref_name }}
name: "${{ github.ref_name }} (${{ steps.pre.outputs.label }})"
Expand Down
11 changes: 7 additions & 4 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ jobs:
# Push core test coverage badge endpoint.json to the data branch so the
- name: Upload coverage to Codecov
if: matrix.os == 'ubuntu-latest' && matrix.python-version == '3.11'
uses: codecov/codecov-action@v5
uses: codecov/codecov-action@v7
with:
token: ${{ secrets.CODECOV_TOKEN }}
files: coverage.xml
Expand All @@ -127,10 +127,13 @@ jobs:
continue-on-error: true # badge push is informational; must not block the build
env:
GITHUB_TOKEN: ${{ github.token }}
QT_QPA_PLATFORM: offscreen
run: |
xvfb-run python -m pytest -p faulthandler tests/core/ -q --cov=src/Synaptipy/core --cov-report=term --cov-report=xml --cov-fail-under=0
CORE_COVERAGE=$(python -m coverage report --format=total 2>/dev/null || echo "0")
# Read coverage collected during the main test run and filter to core/.
# Do NOT re-run pytest here: conftest.py calls os._exit() in
# pytest_sessionfinish, which kills the process before pytest-cov can
# write coverage.xml, causing set -e to abort the script before the
# badge JSON is pushed.
CORE_COVERAGE=$(python -m coverage report --include="*/Synaptipy/core/**" --format=total 2>/dev/null || echo "0")
if [ "$CORE_COVERAGE" -ge 90 ]; then COLOR="brightgreen"
elif [ "$CORE_COVERAGE" -ge 75 ]; then COLOR="green"
elif [ "$CORE_COVERAGE" -ge 60 ]; then COLOR="yellow"
Expand Down
Loading