ci: fix coverage badge push and update actions for Node.js 24#28
Merged
Conversation
Badge fix: the 'Push coverage badge data' step was re-running pytest which triggered conftest.py::pytest_sessionfinish -> os._exit() before pytest-cov could write coverage.xml. With bash set -e, exit code 3 aborted the script before git push ran. Fix: read coverage data already collected by the main test run using python -m coverage report --include='*/Synaptipy/core/**'. No second pytest invocation needed. Node.js 24 (mandatory from 2026-06-16): - codecov/codecov-action v5 -> v7 - actions/github-script v7 -> v9 - softprops/action-gh-release v2 -> v3 Closes dependabot PRs: #23 (action-gh-release), #24 (github-script), #26 (codecov-action)
This was referenced Jun 13, 2026
Coverage report
This PR does not seem to contain any modification to coverable code. |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #28 +/- ##
=========================================
+ Coverage 0 91.55% +91.55%
=========================================
Files 0 55 +55
Lines 0 7826 +7826
=========================================
+ Hits 0 7165 +7165
- Misses 0 661 +661
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Coverage badge showing 0%
The
Push coverage badge datastep was re-running pytest, which triggeredconftest.py::pytest_sessionfinish→os._exit()before pytest-cov couldwrite
coverage.xml. Withset -ein bash, the non-zero exit code abortedthe script before
git pushran. Fix: read coverage data already collectedby the main test run via
python -m coverage report --include='*/Synaptipy/core/**'.No second pytest invocation needed.
Node.js 24 (mandatory from 2026-06-16)
codecov/codecov-actionv5 → v7actions/github-scriptv7 → v9softprops/action-gh-releasev2 → v3Closes #23, #24, #26