Fix Excel theme tint color matching - #360
Open
developer0hye wants to merge 1 commit into
Open
Conversation
Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
This was referenced Aug 29, 2026
Contributor
Author
|
CI note: the formatting job passed. The Rust 1.88 job stops during fresh dependency resolution, before this PR's code is compiled: This PR does not change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
calc_tintconverts theme colors through a floating-point 255-step HLS space. Excel-compatible exports use the 240-step integer HLS model, so several theme tints resolve one or more RGB levels away from native output. For example,DAB6BAat tint0.7999resolves toF8F0F1instead ofF8EFF0.Excel-compatible workbooks also encode common whole-percent tints as nearby signed-short values such as
0.79998168889431442. Treating those values literally can move the resulting color another level.Fix
0.7999Testing
cargo +nightly fmt --all --checkcargo clippy -- -D warningscargo test(116 unit, 113 integration + 2 ignored, 4 streaming + 1 ignored, 79 doc + 20 ignored)Related: #184
Related: developer0hye/office2pdf#1394