fix(xlsx): match native theme tint colors - #1398
Merged
Merged
Conversation
Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
umya-spreadsheetv2 branchtint="0.7999"fill to native Excel's#F8EFF0The dependency fix uses Excel's 240-step integer HLS quantization instead of a floating-point 255-step transform. It is backported in developer0hye/umya-spreadsheet#9 and proposed upstream in MathNya/umya-spreadsheet#360.
Related issue
Related: #1394
Testing
cargo test -p office2pdf test_positive_theme_tint_matches_native_excel_hls_quantizationcargo fmt --all -- --checkcargo clippy --workspace --all-targets -- -D warningscargo test --workspacewasm-pack build crates/office2pdf --target web --features wasm(cd crates/office2pdf && TMPDIR=/Volumes/T7/office2pdf-wasm-1394.R5NDo2 wasm-pack test --node --features wasm)— 10 passedTMPDIR=/Volumes/T7/office2pdf-wasm-1394.R5NDo2 wasm-pack build crates/office2pdf --target web --features wasm-cjk-font(cd crates/office2pdf && TMPDIR=/Volumes/T7/office2pdf-wasm-1394.R5NDo2 wasm-pack test --node --features wasm-cjk-font)— 11 passedpython3 scripts/compare_layout.py <native-Excel-page-1.pdf> <office2pdf-after.pdf> --page 1 --noise-floor 0.5 --audit— 12 matched text blocks, 0 missing/extra/rewrapped, no shift over 5ptpython3 scripts/compare_render.py <native-Excel-page-1.pdf> <office2pdf-after.pdf> --page 1 --dpi 150 --audit— histogram intersection 0.9980, colour shift 0.0001, no material axis difference#F8F0F1to native Excel's#F8EFF0Visual impact
Visual audit
Gift Budget and Tracker1.xlsx(attachment on Gift Budget and Tracker1.xlsx misc issues #982)Startsheet)pdftoppm, 150 DPIfixassets/bugfixes/issue-1394/gt.jpgassets/bugfixes/issue-1394/before.jpgassets/bugfixes/issue-1394/after.jpgVisual comparison
Required inspection
Deviation audit
Startsheet page; the workbook output remains in source sheet order.#F8EFF0, while one header T-junction retains a one-pixel raster seam.Checklist
Signed-off-byline