Backport Excel theme tint color matching to v2 - #9
Merged
developer0hye merged 1 commit intoAug 29, 2026
Conversation
Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
This was referenced Aug 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The office2pdf v2 dependency resolves positive theme tints through a floating-point 255-step HLS space. Native Excel uses integer 240-step HLS behavior, which makes
DAB6BAat tint0.7999resolve toF8EFF0rather thanF8F0F1.Fix
Backport the theme tint correction from MathNya#360 while retaining the v2 public API:
Testing
rustfmt +nightly --edition 2018 --check src/helper/color.rs tests/integration_test.rscargo clippy -- -D warningscargo test(41 unit, 97 integration)Related: MathNya#360
Related: developer0hye/office2pdf#1394