Skip to content

[procmgr] Extract shared Rust client - #54676

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 6 commits into
mainfrom
ilya/procmgr-client-foundation
Aug 13, 2026
Merged

[procmgr] Extract shared Rust client#54676
gh-worker-dd-mergequeue-cf854d[bot] merged 6 commits into
mainfrom
ilya/procmgr-client-foundation

Conversation

@embeaken

@embeaken embeaken commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Extracts a dd-procmgr-client Rust crate from client code in dd-procmgrd:

  • process-manager protobuf/gRPC bindings;
  • default endpoint and DD_PM_SOCKET_PATH handling;
  • Unix socket and Windows named-pipe connections;
  • Windows busy-pipe retry behavior.

The dd-procmgr CLI now uses this crate. The daemon reuses its bindings and endpoint resolution, but keeps all server transport, process supervision, and lifecycle code.

This is a code move and dependency cleanup. It does not change the protocol, endpoint defaults, retry policy, or process-manager behavior.

Why?

A later PR in the Private Action Runner split-mode stack (#54589) adds a second Rust client of dd-procmgrd. Without this crate, that client would either depend on the full daemon implementation or copy its platform-specific connection code.

Validation

dda env dev run -- bazel test //pkg/procmgr/rust/...
dda env dev run -- cargo clippy --manifest-path pkg/procmgr/rust/client/Cargo.toml --all-targets -- -D warnings
dda env dev run -- cargo clippy --manifest-path pkg/procmgr/rust/Cargo.toml --all-targets --features test-helpers -- -D warnings

The Bazel suite covers the client, daemon, CLI, and CLI/daemon E2E tests.

chatgpt-codex-connector[bot]

This comment was marked as outdated.

@embeaken embeaken changed the title ilya/procmgr client foundation [procmgr] Extract shared Rust client Aug 10, 2026
@embeaken embeaken added changelog/no-changelog No changelog entry needed qa/skip-qa labels Aug 10, 2026
@dd-octo-sts

dd-octo-sts Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Files inventory check summary

File checks results against ancestor ae05ce62:

Results for datadog-agent_7.84.0~devel.git.175.a8e8dec.pipeline.130747560-1_amd64.deb:

No change detected

Results for datadog-iot-agent_7.84.0~devel.git.175.a8e8dec.pipeline.130747560-1_amd64.deb:

No change detected

@dd-octo-sts

dd-octo-sts Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor ae05ce6
📊 Static Quality Gates Dashboard
🔗 SQG Job

33 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
agent_deb_amd64 760.081 MiB
agent_deb_amd64_fips 712.942 MiB
agent_heroku_amd64 312.420 MiB
agent_msi 643.525 MiB
agent_rpm_amd64 760.065 MiB
agent_rpm_amd64_fips 712.926 MiB
agent_rpm_arm64 735.964 MiB
agent_rpm_arm64_fips 692.151 MiB
agent_suse_amd64 760.065 MiB
agent_suse_amd64_fips 712.926 MiB
agent_suse_arm64 735.964 MiB
agent_suse_arm64_fips 692.151 MiB
docker_agent_amd64 818.697 MiB
docker_agent_arm64 819.640 MiB
docker_agent_jmx_amd64 1009.594 MiB
docker_agent_jmx_arm64 999.190 MiB
docker_cluster_agent_amd64 210.475 MiB
docker_cluster_agent_arm64 223.455 MiB
docker_cws_instrumentation_amd64 7.439 MiB
docker_cws_instrumentation_arm64 6.877 MiB
docker_dogstatsd_amd64 39.482 MiB
docker_dogstatsd_arm64 37.560 MiB
docker_host_profiler_amd64 305.814 MiB
docker_host_profiler_arm64 317.124 MiB
dogstatsd_deb_amd64 30.224 MiB
dogstatsd_deb_arm64 28.247 MiB
dogstatsd_rpm_amd64 30.224 MiB
dogstatsd_suse_amd64 30.224 MiB
iot_agent_deb_amd64 46.467 MiB
iot_agent_deb_arm64 43.120 MiB
iot_agent_deb_armhf 43.907 MiB
iot_agent_rpm_amd64 46.468 MiB
iot_agent_suse_amd64 46.467 MiB

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Aug 10, 2026

Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Job ID: c57149db-7442-42b9-ae99-3ec9115f5fc5

Baseline: 87ffb12
Comparison: 389bda5
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_metrics_logs memory utilization +1.13 [+0.88, +1.39] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization +0.47 [+0.35, +0.59] 1 Logs bounds checks dashboard
quality_gate_security_idle memory utilization +0.04 [-0.06, +0.15] 1 Logs bounds checks dashboard
quality_gate_security_mean_fs_load memory utilization -0.01 [-0.08, +0.06] 1 Logs bounds checks dashboard
quality_gate_security_no_fs_load memory utilization -0.09 [-0.24, +0.06] 1 Logs bounds checks dashboard
quality_gate_private_action_runner memory utilization -0.19 [-0.31, -0.07] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization -0.32 [-1.20, +0.55] 1 Logs bounds checks dashboard
quality_gate_idle_all_features memory utilization -0.49 [-0.53, -0.45] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
quality_gate_idle intake_connections 10/10 4 = 4 bounds checks dashboard
quality_gate_idle memory_usage 10/10 171.28MiB ≤ 178MiB bounds checks dashboard
quality_gate_idle total_bytes_received 10/10 739.40KiB ≤ 819.20KiB bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 4 = 4 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 517.75MiB ≤ 538MiB bounds checks dashboard
quality_gate_idle_all_features total_bytes_received 10/10 1.13MiB ≤ 1.25MiB bounds checks dashboard
quality_gate_logs intake_connections 10/10 18 ≤ 40 bounds checks dashboard
quality_gate_logs memory_usage 10/10 204.51MiB ≤ 229MiB bounds checks dashboard
quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_logs total_bytes_received 10/10 263.84MiB ≤ 292MiB bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 374.93 ≤ 2000 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 18 ≤ 40 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 404.56MiB ≤ 439MiB bounds checks dashboard
quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_metrics_logs total_bytes_received 10/10 0.94GiB ≤ 1.04GiB bounds checks dashboard
quality_gate_private_action_runner memory_usage 10/10 72.18MiB ≤ 76MiB bounds checks dashboard
quality_gate_security_idle cpu_usage 10/10 28.64 ≤ 100 bounds checks dashboard
quality_gate_security_idle memory_usage 10/10 324.92MiB ≤ 335MiB bounds checks dashboard
quality_gate_security_mean_fs_load cpu_usage 10/10 62.05 ≤ 200 bounds checks dashboard
quality_gate_security_mean_fs_load memory_usage 10/10 305.82MiB ≤ 314MiB bounds checks dashboard
quality_gate_security_no_fs_load cpu_usage 10/10 21.35 ≤ 100 bounds checks dashboard
quality_gate_security_no_fs_load memory_usage 10/10 316.83MiB ≤ 343MiB bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_private_action_runner, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@embeaken
embeaken force-pushed the ilya/procmgr-client-foundation branch from d5933bd to b193496 Compare August 12, 2026 15:47
@embeaken
embeaken force-pushed the ilya/procmgr-client-foundation branch 2 times, most recently from e370777 to 556fd38 Compare August 12, 2026 17:09
@embeaken embeaken added qa/no-code-change No code change in Agent code requiring validation and removed qa/skip-qa long review PR is complex, plan time to review it labels Aug 12, 2026
@embeaken
embeaken marked this pull request as ready for review August 12, 2026 17:58
@embeaken
embeaken requested review from a team as code owners August 12, 2026 17:58
Comment thread pkg/procmgr/rust/client/src/lib.rs
@github-actions github-actions Bot added the long review PR is complex, plan time to review it label Aug 13, 2026
Move protobuf bindings, endpoint resolution, and local client transport into a small procmgr-owned crate. Make dd-procmgr consume that boundary directly while keeping server transport and process supervision in dd-procmgrd.
Let configuration consumers share the platform default without applying the daemon environment override twice.
@embeaken
embeaken force-pushed the ilya/procmgr-client-foundation branch from 1d536fd to a8e8dec Compare August 13, 2026 14:30
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 389bda5 into main Aug 13, 2026
292 checks passed
@github-actions github-actions Bot added this to the 7.84.0 milestone Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog No changelog entry needed internal Identify a non-fork PR long review PR is complex, plan time to review it qa/no-code-change No code change in Agent code requiring validation team/agent-build team/agent-devx team/agent-runtimes team/windows-products

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants