[ACTP] use shared procmgr client from par-control - #54677
Merged
embeaken merged 1 commit intoAug 10, 2026
Merged
Conversation
Adopt the procmgr-owned bindings, endpoint resolution, and local connector. Remove par-control's duplicate Unix and Windows client transport while preserving lazy connection and RPC behavior.
embeaken
merged commit Aug 10, 2026
5403840
into
ilya/par-control-lifecycle
152 of 210 checks passed
Contributor
Author
|
Folded into #54589 by fast-forwarding the lifecycle branch to this head. GitHub therefore marked this PR merged automatically. It is no longer part of stack #54679. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Makes
par-controlconsume the procmgr-owned client crate introduced by #54676.It replaces par-control's local process-manager bindings, endpoint resolution, UDS connector, Windows named-pipe connector, and
ERROR_PIPE_BUSYretry loop withdd-procmgr-client. Executor-specific mTLS remains in par-control and wraps the shared platform stream.Motivation
The process-manager daemon, its CLI, and par-control should use one implementation of platform-sensitive client transport. This prevents endpoint defaults and Windows named-pipe retry behavior from drifting, without coupling par-control to the full
dd-procmgrd-libdaemon implementation.This PR is intentionally separate from the procmgr-owned extraction so the ownership boundary remains clear: #54676 defines and dogfoods the general client API, while this PR contains only Action Platform adoption.
Describe how you validated your changes
The full top-of-stack par-control suite passes after rebasing every later PAR layer over this adoption.
Additional Notes
This PR sits immediately after the lifecycle layer because that is the first layer that introduces a process-manager client. Later executor transport continues using the same shared connector beneath its mTLS wrapper.