Skip to content

fix(a11y): provide a non-empty page label for filesystem roots - #364

Draft
seonghobae wants to merge 1 commit into
masterfrom
fix-root-dir-name-11337586994811845124
Draft

fix(a11y): provide a non-empty page label for filesystem roots#364
seonghobae wants to merge 1 commit into
masterfrom
fix-root-dir-name-11337586994811845124

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Accessibility problem

Java File.getName() returns an empty string for filesystem roots. Rendering that value directly produces an empty document <title> and <h1>, removing the generated page's visible and programmatic location label.

Proposed bounded repair

  • derive one escaped display label per directory;
  • use the directory name when non-empty;
  • use the absolute root path only when the name is empty; and
  • reuse the same label in <title> and the page's <h1>.

Current status

This branch overlaps the same HTML template changed by canonical CSP PR #363 and is intentionally not merge-ready. After #363 integrates, this PR must be rebuilt or updated on the protected master without reverting the exact style-byte/CSP contract.

Before returning to ready-for-review it must also:

  1. remove duplicated conditional rendering by introducing one clearly named display-label value;
  2. prove the behavior through the real generated-file path, including HTML escaping of a fallback path;
  3. preserve ordinary non-root directory labels;
  4. add beginner-readable KDoc where production API is introduced;
  5. add CHANGELOG.md and APA 7 doctoring grounded in current HTML/WCAG primary guidance without claiming formal conformance; and
  6. pass exact-current-head CI, JaCoCo statement/branch coverage, Security Scan, Semgrep, current-head automated review, and independent non-author approval.

Queued, pending, skipped-required, cancelled, absent, stale-head, or failed checks are not success. Duplicate root-label PR checks and reviews are not reusable.

@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 9 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 5bd79666-cad6-4f86-84cc-f7b7d03bce5b

📥 Commits

Reviewing files that changed from the base of the PR and between a3c445e and 6274f00.

📒 Files selected for processing (3)
  • .jules/palette.md
  • src/main/kotlin/html4tree/main.kt
  • src/test/kotlin/html4tree/MainTest.kt

Comment @coderabbitai help to get the list of available commands.

@seonghobae seonghobae changed the title 🎨 Palette: [UX improvement] Fix empty directory name for root directory fix(a11y): provide a non-empty page label for filesystem roots Aug 5, 2026
@seonghobae
seonghobae marked this pull request as draft August 5, 2026 05:25
This was referenced Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant