Skip to content

๐ŸŽจ Palette: ๋นˆ ๋””๋ ‰ํ† ๋ฆฌ ์ด๋ฆ„ ํด๋ฐฑ ์ถ”๊ฐ€ (์ ‘๊ทผ์„ฑ ๊ฐœ์„ ) - #239

Closed
seonghobae wants to merge 1 commit into
masterfrom
palette-empty-dir-fallback-6972211353999789452
Closed

๐ŸŽจ Palette: ๋นˆ ๋””๋ ‰ํ† ๋ฆฌ ์ด๋ฆ„ ํด๋ฐฑ ์ถ”๊ฐ€ (์ ‘๊ทผ์„ฑ ๊ฐœ์„ )#239
seonghobae wants to merge 1 commit into
masterfrom
palette-empty-dir-fallback-6972211353999789452

Conversation

@seonghobae

Copy link
Copy Markdown
Collaborator

๐Ÿ’ก What: ์ด๋ฆ„์ด ๋นˆ ๋””๋ ‰ํ† ๋ฆฌ(์˜ˆ: ์ตœ์ƒ์œ„ ๋ฃจํŠธ ๋“ฑ)์ผ ๋•Œ ์ ˆ๋Œ€ ๊ฒฝ๋กœ๋ฅผ ๋ณด์—ฌ์ฃผ๋„๋ก ํด๋ฐฑ(fallback) ๋ฉ”์ปค๋‹ˆ์ฆ˜์„ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค.
๐ŸŽฏ Why: ๋””๋ ‰ํ† ๋ฆฌ ์ด๋ฆ„์ด ๋น„์–ด ์žˆ์„ ๊ฒฝ์šฐ <title> ๋ฐ <h1> ํƒœ๊ทธ๊ฐ€ ๋น„์–ด ์žˆ์–ด, ํ™”๋ฉด ํŒ๋…๊ธฐ(์Šคํฌ๋ฆฐ ๋ฆฌ๋”) ์‚ฌ์šฉ์ž๊ฐ€ ํ˜„์žฌ ์œ„์น˜๋ฅผ ์ „ํ˜€ ํŒŒ์•…ํ•  ์ˆ˜ ์—†๋Š” ์‹ฌ๊ฐํ•œ ์ ‘๊ทผ์„ฑ ๋ฌธ์ œ๋ฅผ ํ•ด๊ฒฐํ•˜๊ธฐ ์œ„ํ•จ์ž…๋‹ˆ๋‹ค.
๐Ÿ“ธ Before/After: ๋ฃจํŠธ ๋””๋ ‰ํ† ๋ฆฌ ํฌ๋กค๋ง ์‹œ <title></title> -> <title>/absolute/path</title>
โ™ฟ Accessibility: ๋น„์–ด ์žˆ๋Š” ์‹œ๋งจํ‹ฑ ํƒœ๊ทธ(title, h1)๋ฅผ ๋ฐฉ์ง€ํ•˜์—ฌ ํ™”๋ฉด ํŒ๋…๊ธฐ์˜ ํƒ์ƒ‰ ๋ฐ ์ปจํ…์ŠคํŠธ ์ดํ•ด๋„๋ฅผ ํฌ๊ฒŒ ํ–ฅ์ƒ์‹œ์ผฐ์Šต๋‹ˆ๋‹ค.


PR created automatically by Jules for task 6972211353999789452 started by @seonghobae

๋นˆ ์ด๋ฆ„(์˜ˆ: ํŒŒ์ผ ์‹œ์Šคํ…œ ๋ฃจํŠธ)์„ ๊ฐ€์ง„ ๋””๋ ‰ํ† ๋ฆฌ์˜ ๊ฒฝ์šฐ `title`๊ณผ `h1` ํƒœ๊ทธ๊ฐ€ ๋น„์–ด ์žˆ์–ด ์Šคํฌ๋ฆฐ ๋ฆฌ๋” ์ ‘๊ทผ์„ฑ์— ์‹ฌ๊ฐํ•œ ๋ฌธ์ œ๋ฅผ ์ดˆ๋ž˜ํ•˜๋Š” ๊ฒƒ์„ ์ˆ˜์ •ํ–ˆ์Šต๋‹ˆ๋‹ค. ์ด์ œ ์ ˆ๋Œ€ ๊ฒฝ๋กœ๋ฅผ ํด๋ฐฑ์œผ๋กœ ์‚ฌ์šฉํ•ฉ๋‹ˆ๋‹ค.
@google-labs-jules

Copy link
Copy Markdown

๐Ÿ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a ๐Ÿ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copilot AI review requested due to automatic review settings July 22, 2026 03:26

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Adds a fallback display name for directories that have an empty name (e.g., filesystem root) so generated HTML never contains empty <title> / <h1>, improving screen-reader accessibility.

Changes:

  • Add dirName fallback to absolutePath when curr_dir.name is empty, and use it in <title>/<h1>.
  • Add a unit test validating HTML output for an โ€œempty nameโ€ directory case.
  • Document the accessibility learning/action in .jules/palette.md.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File Description
src/main/kotlin/html4tree/main.kt Adds empty-directory-name fallback and uses it in generated HTML title/header.
src/test/kotlin/html4tree/MainTest.kt Adds regression test to ensure <title>/<h1> arenโ€™t empty when dir name is empty.
.jules/palette.md Records the new accessibility guideline about empty directory names.

๐Ÿ’ก Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

val fakeRoot = object : File(tempDir, "fakeRoot") {
override fun getName() = ""
}
fakeRoot.mkdir()
fun process_dir(curr_dir: File, excludeSet: Set<String>? = null, dirFiles: Array<File>? = null){

val exclude: Set<String> = excludeSet ?: process_ignore_file(curr_dir)
val dirName = if (curr_dir.name.isEmpty()) curr_dir.absolutePath else curr_dir.name
<!-- ๋ณด์•ˆ ํ–ฅ์ƒ: ๋ฆฌํผ๋Ÿฌ๋ฅผ ํ†ตํ•œ ๋””๋ ‰ํ† ๋ฆฌ ๊ฒฝ๋กœ ๋…ธ์ถœ ๋ฐฉ์ง€ -->
<meta name="referrer" content="no-referrer">
<title>${curr_dir.getName().escapeHtml()}</title>
<title>${dirName.escapeHtml()}</title>
<body>
<main>
<h1>${curr_dir.getName().escapeHtml()}</h1>
<h1>${dirName.escapeHtml()}</h1>
Comment thread .jules/palette.md
**์กฐ์น˜:** ํ•ญ์ƒ HTML ๋ฌธ์„œ์˜ `<head>` ์˜์—ญ์— `<meta name="color-scheme" content="light dark">` ๋ฉ”ํƒ€ ํƒœ๊ทธ๋ฅผ ๋ช…์‹œ์ ์œผ๋กœ ์ถ”๊ฐ€ํ•˜์—ฌ ๋ธŒ๋ผ์šฐ์ € ์ˆ˜์ค€์—์„œ ์‚ฌ์šฉ์ž์˜ ์‹œ์Šคํ…œ ํ…Œ๋งˆ(๋‹คํฌ ๋ชจ๋“œ ๋“ฑ)๋ฅผ ์™„์ „ํžˆ ์ƒ์†๋ฐ›์•„ ์ผ๊ด€์„ฑ ์žˆ๋Š” ๋„ค์ดํ‹ฐ๋ธŒ UI๋ฅผ ๋ Œ๋”๋งํ•˜๋„๋ก ๋ณด์žฅํ•˜์‹ญ์‹œ์˜ค.

## 2026-07-22 - Empty Directory Name Fallback
**Learning:** When generating HTML for directory structures, directories with empty names (like filesystem roots) result in empty <title> and <h1> tags, causing a severe accessibility issue for screen readers.

Copy link
Copy Markdown
Collaborator Author

Closing as superseded by draft canonical #364. The same root-name fallback is retained there, but #364 is blocked until it is updated after #363, computes one escaped shared display label, proves root and ordinary generated pages, adds APA 7 doctoring and changelog, and passes fresh exact-head quality/security checks plus independent approval. No result from this duplicate head is reused.

@seonghobae seonghobae closed this Aug 5, 2026
@google-labs-jules

Copy link
Copy Markdown

Closing as superseded by draft canonical #364. The same root-name fallback is retained there, but #364 is blocked until it is updated after #363, computes one escaped shared display label, proves root and ordinary generated pages, adds APA 7 doctoring and changelog, and passes fresh exact-head quality/security checks plus independent approval. No result from this duplicate head is reused.

Understood. Acknowledging that this PR is superseded by draft #364 and stopping work on this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants