Consolidate redundant runtime test coverage - #130
Merged
Conversation
yyjeqhc
enabled auto-merge (squash)
August 23, 2026 11:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow up on the test-infrastructure cleanup merged in #127 by consolidating semantically duplicate
webcodexpackage tests without changing production behavior.The final diff is test/test-helper only across 22 files. No production source, schemas, runtime behavior, permissions, timeout policy, or public tool contracts are changed.
Review fix
Pre-PR review found one real coverage regression in the initial consolidation: the combined project-read path-boundary test retained
../traversal but dropped several absolute/deep-traversal cases previously owned by separate tests.A focused follow-up commit restores the complete fail-closed matrix while keeping one consolidated test:
read_file: parent, nested parent, absolute, and deep parent traversallist_project_files: absolute + parent traversalproject_overview: absolute + parent traversalsearch_project_text: absolute + parent traversal plus structuredinvalid_search_requestevidenceReview commit:
8cd87759(Preserve project path coverage in test consolidation).No other correctness blocker was found in the consolidation review.
Why
The previous suite had accumulated many tests that repeated the same fixture construction, polling loops, transport wrapper, or authority assertion with only one changed parameter. That made contract ownership harder to see, increased test maintenance cost, and amplified scheduler-sensitive polling boilerplate.
This follow-up keeps representative/canonical contract owners and expresses genuine input/state matrices directly, while positive async readiness helpers now use bounded wall-clock deadlines rather than fixed yield counts where appropriate.
Validation
cargo test -p webcodex— 2770 passed / 0 failed / 0 ignoredcargo fmt --all -- --check— passedgit diff --check origin/main...HEAD— passedgit diff --check— passedbash scripts/test_inventory.sh --self-test— 2 passedbash scripts/test_inventory.sh— passedBase: current
main @ e2c0f9a8(Measure generic model-facing tool ergonomics (#128)).