Complete final test infrastructure cleanup - #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Final follow-up to the test cleanup merged in #127 and #130. This branch is based directly on current
mainat5fa2aafb(Consolidate redundant runtime test coverage (#130)) and contains four focused cleanup/governance commits:bc27d324Consolidate Runner execution lifecycle tests6fb9a11bConsolidate Runner LSP synchronization testsb09a6bfbComplete test governance cleanup8eb21911Codify test governance rulesThe remaining work closes the test-infrastructure debt that was intentionally left after the earlier cleanup rounds:
TestEnvGuardwait_*vs probe semantics for future developmentNo production runtime behavior change is intended. Changes in production-source files are test-only/test-support adjustments; the non-test changes are CI/test-governance documentation.
Review performed
I independently reviewed this branch before opening the PR rather than relying only on green tests.
origin/mainand this HEAD across all changed Rust files. Only one test was removed outright:utf_encoding_public_conversions.lsp/position.rsunit suite, including Chinese/emoji offsets and invalid mid-codepoint positions.TestEnvGuardagainst the canonical process-global env lock and audited changed tests for obvious nested non-reentrant lock use; no new deadlock path was found.No correctness blocker was found and no additional review-fix commit was necessary.
Validation
On exact HEAD
8eb21911dfdad404b8bef9ca8a1a3dbcade1843d:cargo fmt --all -- --check— passedgit diff --check origin/main...HEAD— passedgit diff --check— passedbash scripts/test_inventory.sh --self-test— 2 passedbash scripts/test_inventory.sh— passedcargo test -p webcodex— 2770 passed / 0 failed / 0 ignoredcargo test -p webcodex-runner— 743 passed / 0 failed / 3 ignoredcargo test -p webcodex-admin— 17 passed / 0 failed / 0 ignoredThe branch is clean, exactly four commits ahead of current
main, and already synchronized toorigin/chore/test-cleanup.Native macOS/Windows CI lanes remain enabled in the workflow and will provide the platform-specific PR validation, including the Windows-only UIA test consolidation.