Skip to content

chore: update esbuild #1240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
asanehisa wants to merge 13 commits into
base: main
Choose a base branch
from
Open

chore: update esbuild #1240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
49b52f4
upgrade esbuild
asanehisa Jun 17, 2026
03c53af
Automated update to THIRD-PARTY-NOTICES from github action's 3rd part…
github-actions[bot] Jun 17, 2026
eea3e78
coderabbit
asanehisa Jun 17, 2026
851cde2
Automated update to THIRD-PARTY-NOTICES from github action's 3rd part…
github-actions[bot] Jun 17, 2026
2542aba
remove unused
asanehisa Jun 17, 2026
3860f4b
Automated update to THIRD-PARTY-NOTICES from github action's 3rd part…
github-actions[bot] Jun 17, 2026
cd01ba0
fix
asanehisa Jun 17, 2026
cd6e3bc
fix
asanehisa Jun 17, 2026
a124c46
fix
asanehisa Jun 17, 2026
4e41b61
align nodes
asanehisa Jun 17, 2026
1c8d79c
Update component screenshots for visual-editor
github-actions[bot] Jun 17, 2026
431ba21
fix starter
asanehisa Jun 18, 2026
2e9105b
Update component screenshots for visual-editor
github-actions[bot] Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"@types/lodash": "^4.14.202",
"@types/minimist": "^1.2.5",
"globals": "^15.8.0",
"@types/node": "^20.10.6",
"@types/node": "^20.0.0",
"@types/prompts": "^2.4.9",
"@types/semver": "^7.5.6",
"oxlint": "1.2.0",
Expand All @@ -52,14 +52,15 @@
"prettier": "^3.3.3",
"prompts": "^2.4.2",
"semver": "^7.5.4",
"tsx": "^4.6.2",
"tsx": "^4.22.4",
"typescript": "^5.3.3",
"yaml": "^2.3.4"
},
"packageManager": "pnpm@10.33.0",
"pnpm": {
"overrides": {
"happy-dom": "20.8.8"
"happy-dom": "20.8.8",
"esbuild": "0.28.1"
},
"peerDependencyRules": {
"allowedVersions": {
Expand Down
183 changes: 0 additions & 183 deletions packages/visual-editor/THIRD-PARTY-NOTICES
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,105 +200,6 @@ Apache License

-----------

The following npm package may be included in this product:

- @microsoft/api-documenter@7.26.32

This package contains the following license:

@microsoft/api-documenter

Copyright (c) Microsoft Corporation. All rights reserved.

MIT License

Permission is hereby granted, free of charge, to any person obtaining
a copy of this software and associated documentation files (the
"Software"), to deal in the Software without restriction, including
without limitation the rights to use, copy, modify, merge, publish,
distribute, sublicense, and/or sell copies of the Software, and to
permit persons to whom the Software is furnished to do so, subject to
the following conditions:

The above copyright notice and this permission notice shall be
included in all copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

-----------

The following npm package may be included in this product:

- @microsoft/api-extractor@7.52.11

This package contains the following license:

@microsoft/api-extractor

Copyright (c) Microsoft Corporation. All rights reserved.

MIT License

Permission is hereby granted, free of charge, to any person obtaining
a copy of this software and associated documentation files (the
"Software"), to deal in the Software without restriction, including
without limitation the rights to use, copy, modify, merge, publish,
distribute, sublicense, and/or sell copies of the Software, and to
permit persons to whom the Software is furnished to do so, subject to
the following conditions:

The above copyright notice and this permission notice shall be
included in all copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

-----------

The following npm package may be included in this product:

- @microsoft/api-extractor-model@7.30.7

This package contains the following license:

@microsoft/api-extractor-model

Copyright (c) Microsoft Corporation. All rights reserved.

MIT License

Permission is hereby granted, free of charge, to any person obtaining
a copy of this software and associated documentation files (the
"Software"), to deal in the Software without restriction, including
without limitation the rights to use, copy, modify, merge, publish,
distribute, sublicense, and/or sell copies of the Software, and to
permit persons to whom the Software is furnished to do so, subject to
the following conditions:

The above copyright notice and this permission notice shall be
included in all copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

-----------

The following npm package may be included in this product:

- @mapbox/maki@8.2.0
Expand Down Expand Up @@ -1028,30 +929,6 @@ Exhibit B - “Incompatible With Secondary Licenses” Notice

-----------

The following npm package may be included in this product:

- picocolors@1.1.1

This package contains the following license:

ISC License

Copyright (c) 2021-2024 Oleksii Raspopov, Kostiantyn Denysov, Anton Verinov

Permission to use, copy, modify, and/or distribute this software for any
purpose with or without fee is hereby granted, provided that the above
copyright notice and this permission notice appear in all copies.

THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.

-----------

The following npm package may be included in this product:

- lucide-react@0.414.0
Expand Down Expand Up @@ -1147,36 +1024,6 @@ SOFTWARE.

-----------

The following npm package may be included in this product:

- prompts@2.4.2

This package contains the following license:

MIT License

Copyright (c) 2018 Terkel Gjervig Nielsen

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.

-----------

The following npm package may be included in this product:

- pure-react-carousel@1.32.0
Expand Down Expand Up @@ -1399,36 +1246,6 @@ SOFTWARE.

-----------

The following npm package may be included in this product:

- tsx@4.20.4

This package contains the following license:

MIT License

Copyright (c) Hiroki Osame <hiroki.osame@gmail.com>

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.

-----------

The following npm package may be included in this product:

- clsx@2.1.1
Expand Down
19 changes: 6 additions & 13 deletions packages/visual-editor/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,6 @@
},
"dependencies": {
"@mapbox/maki": "^8.2.0",
"@microsoft/api-documenter": "^7.26.29",
"@microsoft/api-extractor": "^7.52.8",
"@microsoft/api-extractor-model": "^7.30.6",
"@puckeditor/core": "0.21.2",
"@radix-ui/react-accordion": "^1.2.3",
"@radix-ui/react-alert-dialog": "^1.1.1",
Expand All @@ -85,20 +82,17 @@
"lucide-react": "^0.414.0",
"lz-string": "1.5.0",
"next-themes": "^0.3.0",
"picocolors": "^1.0.1",
"prompts": "^2.4.2",
"pure-react-carousel": "^1.32.0",
"react-collapsed": "^4.1.2",
"react-color": "^2.19.3",
"react-error-boundary": "^5.0.0",
"react-i18next": "^15.5.2",
"react-international-phone": "^4.6.0",
"sonner": "^1.5.0",
"tailwind-merge": "^2.4.0",
"tsx": "^4.16.3"
"tailwind-merge": "^2.4.0"
},
"engines": {
"node": "^18 || ^20.2.0 || ^22"
"node": "^20.6.0 || ^22 || ^24"
},
"packageManager": "pnpm@10.33.0",
"lint-staged": {
Expand All @@ -108,12 +102,14 @@
"devDependencies": {
"@capsizecss/core": "^4.1.3",
"@capsizecss/metrics": "^3.6.2",
"@microsoft/api-extractor": "^7.58.9",
"@microsoft/api-extractor-model": "^7.33.8",
"@testing-library/dom": "^10.4.0",
"@testing-library/react": "^16.3.0",
"@types/fs-extra": "^11.0.4",
"@types/jest-axe": "^3.5.9",
"@types/minimist": "^1.2.5",
"@types/node": "^20.14.11",
"@types/node": "^20.0.0",
"@types/pixelmatch": "^5.2.6",
"@types/pngjs": "^6.0.5",
"@types/prompts": "^2.4.9",
Expand All @@ -127,24 +123,21 @@
"autoprefixer": "^10.4.2",
"awesome-phonenumber": "^7.5.0",
"axe-core": "^4.10.3",
"execa": "^8.0.1",
"fs-extra": "^11.2.0",
"generate-license-file": "^3.5.0",
"gray-matter": "^4.0.3",
"husky": "^9.1.4",
"i18next-cli": "^1.42.0",
"jest-axe": "^10.0.0",
"jsdom": "^24.1.1",
"lint-staged": "^15.2.7",
"minimist": "^1.2.8",
"pixelmatch": "^7.1.0",
"playwright": "1.55.1",
"pngjs": "^7.0.0",
"prettier": "^3.3.3",
"react-icons": "^5.2.1",
"semver": "^7.6.3",
"tailwindcss": "^3.4.6",
"tsup": "8.3.5",
"tsx": "^4.22.4",
"typescript": "^5.5.4",
"uuid": "11.0.3",
"vite": "^5.4.21",
Expand Down
Binary file modified ...hots/PhotoGallerySection/[desktop] version 59 with showSectionHeading false.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
6 changes: 6 additions & 0 deletions packages/visual-editor/vite.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,13 @@ export default defineConfig(() => ({
"@yext/visual-editor": path.resolve(__dirname, "src"),
},
},
optimizeDeps: {
esbuildOptions: {
target: "es2022",

@mkilpatrick mkilpatrick Jun 18, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to target an older version after upgrading esbuild?

@asanehisa asanehisa Jun 18, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh it makes the upgraded esbuild compile to the JS version we're using or else it breaks when testing

@mkilpatrick mkilpatrick Jun 18, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is "JS version we're using?" Like Node version? And is this only for running tests when you say "testing" or do you mean testing the full flow/working for real? If this is specific to running tests only then we shouldn't have it do this for the prod output.

@asanehisa asanehisa Jun 18, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm so target by default assumes all of the latest JavaScript and CSS features are supported, but for us it isn't as we are on Node 20, 22, 24. Google says Node version + browser determines which targets are supported, so it is Node dependent.

And sorry it is for running tests (including testing in fake starter with pnpm run dev) and building (pnpm build). Or else I see
│ Transforming destructuring to the configured target environment ("chrome87", "edge88", "es2020", "firefox78", "safari14"… errors when testing and/or building.

@mkilpatrick mkilpatrick Jun 18, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, just weird we didn't have to do this before

},
},
build: {
target: "es2022",
cssCodeSplit: true,
lib: {
entry: path.resolve(__dirname, "src/index.ts"),
Expand Down
Loading
Loading