Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThis PR updates dependencies across the monorepo with structural changes to the visual-editor package. Root Suggested reviewers
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/visual-editor/package.json`:
- Line 98: Move the tsx dependency from the dependencies section to the
devDependencies section in packages/visual-editor/package.json. The tsx entry
with version ^4.22.4 is currently listed as a production dependency but should
only be listed as a development dependency since it is only used for development
scripting and tooling, not for runtime execution.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 87462486-d9f4-4588-ae9c-4590e816e844
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (5)
package.jsonpackages/visual-editor/THIRD-PARTY-NOTICESpackages/visual-editor/package.jsonpackages/visual-editor/vite.config.tsstarter/package.json
auto-screenshot-update: true
auto-screenshot-update: true
| }, | ||
| optimizeDeps: { | ||
| esbuildOptions: { | ||
| target: "es2022", |
There was a problem hiding this comment.
Why do we need to target an older version after upgrading esbuild?
There was a problem hiding this comment.
Oh it makes the upgraded esbuild compile to the JS version we're using or else it breaks when testing
There was a problem hiding this comment.
What is "JS version we're using?" Like Node version? And is this only for running tests when you say "testing" or do you mean testing the full flow/working for real? If this is specific to running tests only then we shouldn't have it do this for the prod output.
There was a problem hiding this comment.
Hmm so target by default assumes all of the latest JavaScript and CSS features are supported, but for us it isn't as we are on Node 20, 22, 24. Google says Node version + browser determines which targets are supported, so it is Node dependent.
And sorry it is for running tests (including testing in fake starter with pnpm run dev) and building (pnpm build). Or else I see
│ Transforming destructuring to the configured target environment ("chrome87", "edge88", "es2020", "firefox78", "safari14"… errors when testing and/or building.
There was a problem hiding this comment.
Ok, just weird we didn't have to do this before
For this vuln, have esbuild be 0.28.1 everywhere.
Additionally removed some dependencies that weren't used in packages/visual-editor and moved others only used in dev to devDependencies.
And aligned all the nodes to
"node": "^20.6.0 || ^22 || ^24"(already was done in other package.json files)