Add message channels for handle reference counting#334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Introduce deferred asset handle reference counting through a dedicated asset channel and separate handle lifecycle management from asset storage.
Solution
The previous implementation tightly coupled
Handlereference counting to theAssetsresource. Cloning or dropping a handle immediately mutated asset reference counts, requiring handles to retain a direct reference to the assets container. This made handle lifecycle management difficult to decouple from asset storage and complicated serialization/snapshot workflows. This introduces anAssetChannelthat queues handle lifecycle operations and processes them during the asset container update phase.Why this approach:
Showcase
N/A
Migration guide
Breaking changes
Behaviour changes
Reference count updates are no longer applied immediately.
Checklist