Rename parsers to importers#332
Merged
Merged
Conversation
28c8827 to
cc72387
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Rename the asset import pipeline from Parser to Importer to better reflect its responsibility and align terminology with the existing Exporter abstraction. The primary goal is to make asset serialization and deserialization concepts symmetrical:
Importer.deserialize()Exporter.serialize()Secondary changes include renaming plugins, registration systems, resources, and examples to use the new importer terminology consistently.
Solution
The former
Parserabstraction has been renamed toImporter.Showcase
Before
After
Migration guide
Rename Parser to Importer
Replace:
with:
Rename parse()
Replace:
with:
Rename
AssetServerregistration APIsReplace:
with:
Replace:
with:
Rename plugin usage
Replace:
with:
Rename built-in engine importers
Replace:
with:
Checklist