fix(security): override esbuild to ^0.28.1 (Dependabot #6, RCE)#17
Merged
Conversation
esbuild < 0.28.1 ships a Deno module that downloads native binaries without integrity verification, enabling RCE via a hostile NPM_CONFIG_REGISTRY (GHSA / CVSS 8.1). esbuild is a dev-only transitive dep here (tsx/vite/vitest) and is not in the published package (only dist/ ships), and truecast is a Node project that never exercises the vulnerable Deno path — so practical exposure is low — but this clears the alert and hardens the build/CI path. Dependabot couldn't bump it (transitive, pinned by parents), so force it with a pnpm override; parents allow ^0.28.0, which 0.28.1 satisfies. Lockfile resolves esbuild 0.28.1 everywhere. Full suite green. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a
pnpm.overridesentry forcing esbuild^0.28.1, resolving Dependabot alert #6 (esbuild missing binary integrity verification in the Deno module → RCE viaNPM_CONFIG_REGISTRY, CVSS 8.1). Lockfile now resolves esbuild0.28.1everywhere (was0.28.0).Why an override
esbuild is a transitive dep (tsx / vite / vitest) and Dependabot couldn't bump it — the parents pin
0.28.0. The parents' ranges allow^0.28.0, which0.28.1satisfies, so a pnpm override is the clean fix.Risk context (why this is lower-severity for truecast than the 8.1 suggests)
dependencies) and not in the published package (onlydist/ships) — no consumer of@wastedcode/truecastever receives it.NPM_CONFIG_REGISTRY.Still worth taking: clears the High alert and hardens the build/CI path.
Test plan
pnpm install --frozen-lockfileclean; esbuild0.28.1everywherepnpm typecheck/pnpm test(159 passing) /pnpm lint/pnpm buildall greentruecast publish --checkclean🤖 Generated with Claude Code