feat(web): copy thread ID from issue cards - #297
Merged
Conversation
Load and cache runtime data lazily on the first menu open, falling back to the newest valid thread ID across runs. Add disabled states, existing success/error toasts, i18n strings, and regression tests.\n\nVerification:\n- npm test -- --run src/features/issues/components/card/index.test.tsx\n- npm run typecheck
Share an issue ID keyed Promise cache across the page lifetime so in-flight, successful, and failed runtime loads are reused. Add remount, loading-state, and i18n contract tests.\n\nVerification:\n- 26 tests\n- typecheck
Replace the module-scoped thread ID cache with an issue-scoped React Query hook and provide a shared QueryClient to the app and Storybook. Preserve lazy loading, remount caching, and silent failure behavior.\n\nVerified with npm test, npm run typecheck, and npm run build.
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue カードから Thread ID をコピー
Summary
Issue カードの三点リーダーメニューから、対象 issue に紐づく直近の有効な Thread ID をコピーできるようにします。
主な変更点:
やったこと
動作確認
npm test -- --run src/features/issues/components/card/index.test.tsx src/lib/i18n.test.tsnpm run typecheckgit diff --checkレビュー & 動作確認 チェックリスト
推奨テスト計画:
その他気になることや相談ごと
特になし