-
Notifications
You must be signed in to change notification settings - Fork 100
Place single rail-only decoupling capacitors beside their chips #193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
mohan-bee
wants to merge
10
commits into
tscircuit:main
Choose a base branch
from
mohan-bee:agent/place-single-decoupling-cap
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
7b6e365
Place single rail-only decoupling capacitors beside chips
mohan-bee 363a1a2
Place grounded input capacitors at the configured chip gap
mohan-bee d6a72c1
Give unanchored decoupling rows additional clearance
mohan-bee 79ea880
Require explicit power-net metadata for input capacitors
mohan-bee 68972ae
Revert "Require explicit power-net metadata for input capacitors"
mohan-bee e2a3f34
Revert "Give unanchored decoupling rows additional clearance"
mohan-bee 8d8f4fa
Revert "Place grounded input capacitors at the configured chip gap"
mohan-bee 17cbf12
Space unanchored decoupling rows from power chips
mohan-bee eba32c2
Keep decoupling rows outside doubled chip clearance
mohan-bee 515c4f9
Enforce doubled clearance for decoupling rows
mohan-bee File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
tests/repros/__snapshots__/repro-adxl345-sch-auto-layout.snap.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
12 changes: 6 additions & 6 deletions
12
tests/repros/__snapshots__/repro-rp2040-power-supply-section.snap.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,36 @@ | ||
| import { expect, test } from "bun:test" | ||
| import { LayoutPipelineSolver } from "lib/solvers/LayoutPipelineSolver/LayoutPipelineSolver" | ||
| import type { InputProblem } from "lib/types/InputProblem" | ||
| import { getRotatedSize } from "lib/utils/rotatePinOffset" | ||
| import inputProblem from "../assets/repro-power-section.input.json" | ||
|
|
||
| test("power section schematic auto-layout", async () => { | ||
| const solver = new LayoutPipelineSolver(inputProblem as InputProblem) | ||
| solver.solve() | ||
|
|
||
| const placements = solver.getOutputLayout().chipPlacements | ||
| const c1Size = getRotatedSize( | ||
| inputProblem.chipMap.C1!.size, | ||
| placements.C1!.ccwRotationDegrees, | ||
| ) | ||
| const u3Size = getRotatedSize( | ||
| inputProblem.chipMap.U3!.size, | ||
| placements.U3!.ccwRotationDegrees, | ||
| ) | ||
| const horizontalGap = Math.max( | ||
| placements.U3!.x - u3Size.x / 2 - (placements.C1!.x + c1Size.x / 2), | ||
| placements.C1!.x - c1Size.x / 2 - (placements.U3!.x + u3Size.x / 2), | ||
| 0, | ||
| ) | ||
| const verticalGap = Math.max( | ||
| placements.U3!.y - u3Size.y / 2 - (placements.C1!.y + c1Size.y / 2), | ||
| placements.C1!.y - c1Size.y / 2 - (placements.U3!.y + u3Size.y / 2), | ||
| 0, | ||
| ) | ||
| expect(Math.hypot(horizontalGap, verticalGap)).toBeGreaterThanOrEqual( | ||
| inputProblem.chipGap * 2, | ||
| ) | ||
| expect(solver.checkForOverlaps(solver.getOutputLayout())).toHaveLength(0) | ||
|
|
||
| await expect(solver).toMatchSolverSnapshot(import.meta.path) | ||
| }) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
refrence