Skip to content

Warn when differential pairs are not point to point - #3011

Merged
0hmX merged 11 commits into
mainfrom
agent/validate-differential-pair-point-to-point
Aug 5, 2026
Merged

Warn when differential pairs are not point to point#3011
0hmX merged 11 commits into
mainfrom
agent/validate-differential-pair-point-to-point

Conversation

@0hmX

@0hmX 0hmX commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Implements tscircuit/rfc#13.

End-to-end workflow

  1. Core parses <differentialpair> and retains its name, positiveConnection, and negativeConnection in the component tree.
  2. Core renders the subcircuit's source traces, source ports, source nets, and connectivity-map keys.
  3. During SourceDesignRuleChecks, the differential-pair component validates the positive and negative connections independently.
  4. For each connection, Core resolves a named trace or port selector to one subcircuit connectivity group.
  5. Core collects the terminal source ports in that connectivity group.
  6. Exactly two terminal ports is valid and produces no diagnostic.
  7. Any other terminal count stores a source_property_ignored_warning in Core's Circuit JSON database. The warning identifies the pair, property, resolved net or selector, terminal pins, and suggested correction.
  8. When the component updates or is removed, Core deletes the warnings previously owned by that differential pair before recalculating, preventing stale or duplicate warnings.
  9. circuit.getCircuitJson() serializes the warning with the rest of the circuit.
  10. A follow-up CLI change will classify and display this stored diagnostic when a user runs tsci check netlist <file>.

@vercel

vercel Bot commented Aug 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
tscircuit-core-benchmarks Ready Ready Preview Aug 5, 2026 10:29am

Request Review

@0hmX 0hmX changed the title Validate differential pairs are point to point Warn when differential pairs are not point to point Aug 5, 2026
@0hmX
0hmX force-pushed the agent/validate-differential-pair-point-to-point branch from cf8955b to f1d7441 Compare August 5, 2026 01:06
@0hmX
0hmX marked this pull request as ready for review August 5, 2026 01:55
Comment thread lib/components/primitive-components/DifferentialPair.ts Outdated

@seveibar seveibar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

@0hmX
0hmX merged commit b11d8e0 into main Aug 5, 2026
17 checks passed
@0hmX
0hmX deleted the agent/validate-differential-pair-point-to-point branch August 5, 2026 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants