Clarify differential pair ambiguity warnings - #3017
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #3011.
What changed
expected exactly 2 terminal pins, found N.Why
Core does not ignore or rewrite the differential-pair connection. The diagnostic should state the topology problem without prescribing a circuit or selector change. A named trace is ambiguous when its resolved connection contains more than two terminal pins; other invalid counts are simply not point-to-point.
Developer impact
Users receive concise, non-prescriptive diagnostics that identify the actual connection problem and list the affected pins.
Validation
bunx tsc --noEmitgit diff --check