Feature/rabbit hole tap playlist#462
Draft
Netfreak25 wants to merge 11 commits into
Draft
Conversation
…erse-engineering/develop Next Version
This reverts commit 569ee6d.
…erse-engineering/develop v0.6.8
…tHole-tap-playlist
Collaborator
|
Your pr is kind of escalating ^^ Not sure if your ai agents fucked up with committing those changes |
Author
|
damn - indeed - this was not the intention |
27bcb1c to
5b3f8e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds backend support for TAP playlist generation and streaming, with a fast path for stable TAF-only playlists.
The main goal is to make stable TAP playlists streamable on first download, cacheable after generation, and safe across freshness checks without changing Cyclone/vendor code.
What changed
.taf.tmpfile.Content-Lengthbefore the response body starts.shufflemissing or0).tafis published only after generation and HTTP delivery have completed.audio_id..taffiles whose headeraudio_idno longer matches the TAP playlistaudio_id.jsonGetUInt32(), so existing persisted playlist metadata such as"audio_id": "123"is handled correctly.docs/TAP_PLAYLIST_BACKEND.md.Scope boundaries
handler_cloud.c.Testing
Build:
make buildcompleted successfully on the test host.Manual smoke testing:
audio_idchange triggers exactly one rebuild/redownload.taftriggers rebuild and republish.tafwith old headeraudio_idis not reusedshuffle == allshuffle == oneshuffle == onewith more than 99 candidate entriesshuffle == none/allwith more than 99 entries is rejected cleanly.tafvalidates after publish.taf.tmpis removed after successful publish.replace.bakdoes not remain after successful publishReview focus
The most relevant areas to review are:
src/handler_cloud.csrc/tonie_audio_playlist.csrc/toniefile.cdocs/TAP_PLAYLIST_BACKEND.md