ci(windows): fix Build windows by locating vcvars64.bat via vswhere (windows-2025-vs2026)#463
Merged
SciLor merged 1 commit intoJun 18, 2026
Conversation
…path The build-windows-amd64 job hardcoded the Visual Studio install path (2022\Enterprise). GitHub is migrating the windows-latest runner image to windows-2025-vs2026, which no longer has that path, so the "Build windows" step fails immediately with "The system cannot find the path specified." This currently breaks every PR and the develop branch. Use vswhere.exe (always present at the fixed Installer location) to resolve the active VS installation dynamically and call its vcvars64.bat. This works across VS versions/editions and keeps the existing make-based build intact. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
b0697bf
into
toniebox-reverse-engineering:develop
32 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
build-windows-amd64job inbuild_release.ymlhardcodes the Visual Studio install path:GitHub is migrating the
windows-latestrunner image towindows-2025-vs2026(runner notice: "windows-latest requests are being redirected to windows-2025-vs2026 by June 15, 2026"). The new image no longer has the2022\Enterprise\path, so the Build windows step fails instantly with:This is environmental and breaks every PR plus
developitself — confirmed failing ondevelop(2026-06-13), #461 (2026-06-14), and #462 (2026-06-16), all at the same step.Fix
Resolve the active Visual Studio installation dynamically with
vswhere.exe(always present at the fixedInstallerlocation) and call itsvcvars64.bat. This is version/edition-agnostic and keeps the existingmake-based build unchanged.microsoft/setup-msbuildwas considered but is insufficient here: it only adds MSBuild toPATHand does not set up thecl.exe/C++ toolchain environment that themakebuild requires.Impact
Unblocks the Windows build for all open PRs (#461, #462) and future ones. No code changes — CI workflow only.
🤖 Generated with Claude Code