Skip to content

fix: pin a dated nightly toolchain for reproducible builds#14

Open
JoshuaBearup wants to merge 1 commit into
tomWhiting:mainfrom
JoshuaBearup:fix/pin-dated-nightly
Open

fix: pin a dated nightly toolchain for reproducible builds#14
JoshuaBearup wants to merge 1 commit into
tomWhiting:mainfrom
JoshuaBearup:fix/pin-dated-nightly

Conversation

@JoshuaBearup

@JoshuaBearup JoshuaBearup commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Fixes #12.

Pins nightly-2026-07-01 (rustc 1.98.0-nightly, f46ec5218) instead of bare nightly, so every host builds with the same compiler and toolchain drift stops being a suspect for new build failures. Bump the date deliberately when you want a newer nightly.

Verified: cargo check --workspace green on x86_64 Linux under exactly this toolchain, in combination with the libyggd re-lock (#13) — the lock at 697f6d2 fails on Linux on any nightly, so Linux verification requires both. On macOS this pin is safe standalone.

If nothing still requires nightly features, pinning a stable release would be even better — happy to rework the PR to stable if you prefer.

Summary by CodeRabbit

  • Chores
    • Updated the project to use a specific Rust nightly toolchain version for more consistent builds.

A bare 'channel = nightly' resolves to whatever nightly is current on
the build host, so two machines (or the same machine a week apart)
silently build with different compilers, and toolchain drift becomes
a plausible suspect for any new build failure.

Pin nightly-2026-07-01 (rustc 1.98.0-nightly f46ec5218), verified:
cargo check --workspace green on x86_64 Linux under this exact
toolchain (in combination with the libyggd re-lock from tomWhiting#11 — the
lock at 697f6d2 fails on Linux regardless of toolchain). Bump the
date deliberately as needed.

Closes tomWhiting#12
@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 12154dcb-b36b-4b44-be55-003e82e4966f

📥 Commits

Reviewing files that changed from the base of the PR and between 39bf32b and 32b45b0.

📒 Files selected for processing (1)
  • rust-toolchain.toml

📝 Walkthrough

Walkthrough

The rust-toolchain.toml file is updated to pin the Rust toolchain to a specific dated nightly version, nightly-2026-07-01, replacing the previous generic nightly channel reference.

Changes

Toolchain Pinning

Layer / File(s) Summary
Pin dated nightly version
rust-toolchain.toml
Toolchain channel changed from generic nightly to nightly-2026-07-01 for reproducible builds.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Related issues: #12

Suggested labels: dependencies, toolchain

Suggested reviewers: tomWhiting

🐰 Poem

A nightly drift, a build gone strange,
Now pinned in time, no more to range.
One date to rule the compiler's fate,
Nightly-two-six, oh-seven, eight—
No wait, oh-one! The rabbit hops in tune,
Reproducible builds beneath the moon. 🌙

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: pinning a dated nightly toolchain for reproducible builds.
Linked Issues check ✅ Passed The PR satisfies #12 by replacing bare nightly with a dated nightly pin in rust-toolchain.toml.
Out of Scope Changes check ✅ Passed The change is narrowly scoped to the toolchain pin and adds no unrelated modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rust-toolchain.toml pins bare "nightly" — non-reproducible builds across hosts/time

1 participant