fix: pin a dated nightly toolchain for reproducible builds#14
fix: pin a dated nightly toolchain for reproducible builds#14JoshuaBearup wants to merge 1 commit into
Conversation
A bare 'channel = nightly' resolves to whatever nightly is current on the build host, so two machines (or the same machine a week apart) silently build with different compilers, and toolchain drift becomes a plausible suspect for any new build failure. Pin nightly-2026-07-01 (rustc 1.98.0-nightly f46ec5218), verified: cargo check --workspace green on x86_64 Linux under this exact toolchain (in combination with the libyggd re-lock from tomWhiting#11 — the lock at 697f6d2 fails on Linux regardless of toolchain). Bump the date deliberately as needed. Closes tomWhiting#12
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe rust-toolchain.toml file is updated to pin the Rust toolchain to a specific dated nightly version, nightly-2026-07-01, replacing the previous generic nightly channel reference. ChangesToolchain Pinning
Estimated code review effort: 1 (Trivial) | ~2 minutes Related issues: Suggested labels: dependencies, toolchain Suggested reviewers: tomWhiting 🐰 PoemA nightly drift, a build gone strange, 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Fixes #12.
Pins
nightly-2026-07-01(rustc 1.98.0-nightly, f46ec5218) instead of barenightly, so every host builds with the same compiler and toolchain drift stops being a suspect for new build failures. Bump the date deliberately when you want a newer nightly.Verified:
cargo check --workspacegreen on x86_64 Linux under exactly this toolchain, in combination with the libyggd re-lock (#13) — the lock at697f6d2fails on Linux on any nightly, so Linux verification requires both. On macOS this pin is safe standalone.If nothing still requires nightly features, pinning a stable release would be even better — happy to rework the PR to stable if you prefer.
Summary by CodeRabbit