Skip to content

fix: re-lock libyggd past aebe85d so norn builds on Linux from its own Cargo.lock#13

Open
JoshuaBearup wants to merge 1 commit into
tomWhiting:mainfrom
JoshuaBearup:fix/relock-libyggd-linux
Open

fix: re-lock libyggd past aebe85d so norn builds on Linux from its own Cargo.lock#13
JoshuaBearup wants to merge 1 commit into
tomWhiting:mainfrom
JoshuaBearup:fix/relock-libyggd-linux

Conversation

@JoshuaBearup

Copy link
Copy Markdown
Collaborator

Fixes #11.

Lock-only change: cargo update -p libyggd --precise aebe85d470a894d56f9f94fe26b483d15c2687d9.

  • libyggd 697f6d2aebe85d — the commit that fixed the Linux statfs block_size() type error (E0277: u64: From<i64> at cow_clone.rs:412; block_size() is i64 on Linux/glibc, u32 on macOS).
  • Transitive deps the new rev no longer pulls are removed (ctrlc, block2, the windows-* chain). No other package versions moved.

Verified: cargo check --workspace green on x86_64 Linux (previously failed with the E0277 above, independent of toolchain version). aebe85d was chosen as the minimal step past the broken call site to keep drift small — re-locking to current yggdrasil main (which platform-gates the same call site) also works if you'd rather jump further.

Companion: #14 pins a dated nightly (#12) — verified together on Linux.

The committed Cargo.lock pinned libyggd at 697f6d2, which fails to
compile on Linux/glibc (E0277 at cow_clone.rs:412 — statfs
block_size() is i64 on Linux, u32 on macOS, so u64::from only
type-checks on macOS). Re-lock to aebe85d, the commit that fixed
that call site.

Lock-only change: libyggd 697f6d2 -> aebe85d plus removal of
transitive deps the new rev no longer pulls (ctrlc, block2, the
windows-* chain). No other package versions moved.

Verified: cargo check --workspace green on x86_64 Linux (previously
failed with the E0277 above).

Closes tomWhiting#11
@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 698ebb4f-7f1a-4d17-a2b7-507ce711ca33

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Committed Cargo.lock pins a Linux-unbuildable libyggd rev (697f6d2, pre-aebe85d) — norn cannot build on Linux from its own lock

1 participant