resourcecontrol, tikvrpc: backport RC paging pre-charge hint#2020
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
f9f4b2b to
b5a120c
Compare
|
/retest |
|
@YuhaoZhang00: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
|
@JmPotato: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfzjywxk, rleungx, YuhaoZhang00 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
520a563
into
tikv:release-nextgen-202603
Problem
Backport the client-go transport required by the merged tikv/pd#11003 so TiDB can provide a predicted read-bytes hint for request-side resource-control pre-charge on
release-nextgen-202603.Changes
release-nextgen-202603merge of client/resource_group: backport RC pre-charge and runtime state pd#11003 (v0.0.0-20260716095117-1636e69a936b).tikvrpc.Request.PredictedReadBytesand expose the hint through resource-controlRequestInfo.The hint is internal to client-go and does not change the TiKV wire protocol. A zero hint preserves the existing settlement-only behavior.
Dependencies and source
Tests
Known CI results:
integration-tikvfailed in the timing-sensitiveTestSnapshotFail/TestRetryPointGetResolveTS, outside the changed resource-control paths. A job-only rerun requires maintainer permission.pull-integration-test-release-nextgenfails because the release branch lacks the TiDB-like key encoding test fix from tests: use TiDB-like keys in next-gen integration tests #2010 (00f57d88370fa62fb83e895f05a73fabb499904e). That fix should be backported separately rather than mixed into this feature backport.Compatibility
No wire-protocol change. Existing callers that do not set
PredictedReadBytesretain the previous behavior. The backport intentionally keeps the release branch's existing PD client APIs and dependency baseline.