coprocessor: backport paging limits to release-nextgen-202603#1501
Merged
ti-chi-bot[bot] merged 2 commits intoJul 16, 2026
Conversation
Signed-off-by: artem_danilov <artem.danilov@airbnb.com> (cherry picked from commit bb32227) Signed-off-by: JmPotato <github@ipotato.me>
Add a new uint64 field `paging_size_bytes` (field 17) to the coprocessor Request message. When set, TiKV will stop scanning when accumulated scanned bytes reach this limit, enabling byte-budget paging for finer-grained Resource Control. Note: rebased onto upstream master where field 16 is now taken by max_keys_read (pingcap#1450), so paging_size_bytes was bumped from field 16 to field 17. Signed-off-by: JmPotato <github@ipotato.me> (cherry picked from commit a15c348) Signed-off-by: JmPotato <github@ipotato.me>
cfzjywxk
approved these changes
Jul 16, 2026
rleungx
approved these changes
Jul 16, 2026
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfzjywxk, rleungx The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
Bot
merged commit 3631780
into
pingcap:release-nextgen-202603
2 checks passed
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Backport the coprocessor request fields required by byte-budget paging to
release-nextgen-202603:max_keys_readas field 16 from copr: add max_keys_read coprocessor Request #1447, which is the field-number prerequisite for the source paging change.paging_size_bytesas field 17 from proto: add paging_size_bytes to coprocessor.Request #1448.Both fields are optional
uint64fields. A zero value keeps the existing behavior.Why
The TiDB Resource Control paging backport needs
coprocessor.Request.paging_size_byteswhile remaining on the kvprotorelease-nextgen-202603lineage instead of consuming a master-only commit.Related downstream PRs:
Source commits
bb322278e9e549252dcbb6acc73071afd9908095(copr: add max_keys_read coprocessor Request #1447)a15c348f8713e5c492b6dfb41224c464b5824979(proto: add paging_size_bytes to coprocessor.Request #1448)Each source commit is preserved as a separate signed-off cherry-pick with provenance.
Tests