Say what a release is missing before spending six minutes on it - #3
Merged
Conversation
With no signing key the bundler is handed an empty string, tries to read it as a minisign secret and reports "Missing comment in secret key" — which reads as a broken key when the truth is that there is no key. The run got that far only after building the whole app and the installer. Checked first now, in seconds, naming both halves: the private one as a secret and the public one in tauri.conf.json, which is just as absent and would leave the shipped app unable to verify anything it downloaded.
This was referenced Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release run on
mainfails at the last step:That reads as a broken key. It is not — there is no key. The repository has zero Actions secrets, so
TAURI_SIGNING_PRIVATE_KEYexpands to an empty string, the bundler tries to parse it as a minisign secret, and the parser complains about the comment line an empty string does not have. It got that far only after compiling the whole app and producing the installer.This checks first, in seconds, and names both halves — because the public one is missing too:
mainTAURI_SIGNING_PRIVATE_KEYTAURI_SIGNING_PRIVATE_KEY_PASSWORDplugins.updater.pubkey""The public key matters as much as the private one: with it empty, a signed installer would still ship an app that cannot verify anything it downloads.
What still has to happen outside this PR
The public half goes into
plugins.updater.pubkeyinsrc-tauri/tauri.conf.jsonas its own commit; the private half and its password become the two secrets. The private half never enters the repository.🤖 Generated with Claude Code