Give the updater a public key to check signatures against - #4
Merged
Conversation
The placeholder left when the updater was wired up. Without it a signed installer would still ship an app that verifies nothing it downloads, which is the whole point of signing one. `.gitignore` gains the keys as well. The command the documentation gives writes the private half into the working directory, this repository is public, and one `git add -A` is the entire distance between those two facts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fills in
plugins.updater.pubkey, which has been an empty placeholder since the updater was wired up. Without it a signed installer still ships an app that verifies nothing it downloads — which is the whole point of signing one.The value is the content of
openeventviewer.key.pubverbatim, the same form the other Tauri projects on this machine use..gitignoregains*.keynpx tauri signer generate -w openeventviewer.keywrites the private half into the working directory. It landed in this repository's root, this repository is public, and onegit add -Awas the entire distance between those two facts. It was never staged and never reached the history — checked — but the guard belongs here regardless.Still to do, outside this PR
The private half has to become the secret
TAURI_SIGNING_PRIVATE_KEY. Until it does, the release stops at the preflight added in #3 rather than after a six-minute build.🤖 Generated with Claude Code