Skip to content

Fix spelling error in Logo component acronym attribute #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DeveloperBatuhanALGUL wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix spelling error in Logo component acronym attribute #179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion app/components/ch/components/Logo.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@
</svg>
<div class="logo__separator" role="separator" aria-hidden="true" />
<div class="logo-title__container">
<div class="logo__accronym" v-html="accronym" />
<div class="logo__accronym" v-html="acronymValue" />
<div class="logo__title">
<div v-html="title" />
<div v-if="isEasyLanguage" class="badge-easy-language">
Expand Down Expand Up @@ -306,6 +306,11 @@ const props = defineProps({
required: false,
default: () => '',
},
acronym: {
type: String,
required: false,
default: () => '',
},
link: {
type: String,
required: false,
Expand All @@ -332,4 +337,6 @@ const computedLogoClass = computed(() => {
return 'logo__flag'
}
})

const acronymValue = computed(() => props.acronym || props.accronym)
</script>
4 changes: 2 additions & 2 deletions app/components/ch/sections/TopHeader.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<div class="container container--flex">
<Logo
title="Eidgenössisches Departement für Verteidigung, <br/>Bevölkerungsschutz und Sport"
accronym="DSS"
acronym="DSS"
:class="overrideLogoForPrint ? 'logo--print-hidden' : ''"
:isFreebrand="isFreebrand"
:isEasyLanguage="isEasyLanguage"
Expand All @@ -18,7 +18,7 @@
<Logo
v-if="overrideLogoForPrint"
title="Staatssekretariat für Wirtschaft"
accronym="SECO"
acronym="SECO"
:class="overrideLogoForPrint ? 'logo--print-only' : ''"
/>
<div v-if="isEasyLanguage" class="icon-header-mobile icon-easy-language">
Expand Down
4 changes: 2 additions & 2 deletions app/components/stories/components/Logo.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ export default {

export const Logotype = {
components: { Logo },
template: '<Logo :title="title" :accronym="accronym" />',
template: '<Logo :title="title" :acronym="acronym" />',
args: {
title: 'Design System for <br/>the Swiss Confederation',
accronym: 'DSS',
acronym: 'DSS',
},
}